webrtc/modules/audio_device/audio_device_impl.h - Issue 2214003002: GYP->GN of audio_device_tests. Remove dead code. Fix new warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_device/audio_device_impl.h

Issue 2214003002: GYP->GN of audio_device_tests. Remove dead code. Fix new warnings. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Exclude tests for ios. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_device/BUILD.gn ('K') | « webrtc/modules/audio_device/audio_device_generic.cc ('k') | webrtc/modules/audio_device/audio_device_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_device/audio_device_impl.h

diff --git a/webrtc/modules/audio_device/audio_device_impl.h b/webrtc/modules/audio_device/audio_device_impl.h

index 044ec4ed6b52cf8b086cb0b610a9f010b50fd2c1..034690f6b25b14c80ba8854b256de914efb8beb9 100644

--- a/webrtc/modules/audio_device/audio_device_impl.h

+++ b/webrtc/modules/audio_device/audio_device_impl.h

@@ -42,7 +42,7 @@ class AudioDeviceModuleImpl : public AudioDeviceModule {

int32_t AttachAudioBuffer();

AudioDeviceModuleImpl(const int32_t id, const AudioLayer audioLayer);

- virtual ~AudioDeviceModuleImpl();

+ ~AudioDeviceModuleImpl() override;

int64_t TimeUntilNextProcess() override;

void Process() override;

@@ -178,7 +178,6 @@ class AudioDeviceModuleImpl : public AudioDeviceModule {

int32_t SetLoudspeakerStatus(bool enable) override;

int32_t GetLoudspeakerStatus(bool* enabled) const override;

- bool BuiltInAECIsEnabled() const override;

bool BuiltInAECIsAvailable() const override;

int32_t EnableBuiltInAEC(bool enable) override;

bool BuiltInAGCIsAvailable() const override;

@@ -186,8 +185,10 @@ class AudioDeviceModuleImpl : public AudioDeviceModule {

bool BuiltInNSIsAvailable() const override;

int32_t EnableBuiltInNS(bool enable) override;

+#if defined(WEBRTC_IOS)

int GetPlayoutAudioParameters(AudioParameters* params) const override;

int GetRecordAudioParameters(AudioParameters* params) const override;

+#endif // WEBRTC_IOS

int32_t Id() { return _id; }

#if defined(WEBRTC_ANDROID)