Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: webrtc/modules/audio_device/BUILD.gn

Issue 2214003002: GYP->GN of audio_device_tests. Remove dead code. Fix new warnings. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Exclude tests for ios. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_device/BUILD.gn
diff --git a/webrtc/modules/audio_device/BUILD.gn b/webrtc/modules/audio_device/BUILD.gn
index 35a99eaac7e6cae274ddb9607b6d17cc175eaa7e..34c15a1ad50414f87a0b8c32edc0f9dbafd30c32 100644
--- a/webrtc/modules/audio_device/BUILD.gn
+++ b/webrtc/modules/audio_device/BUILD.gn
@@ -29,17 +29,20 @@ source_set("audio_device") {
"../..:webrtc_common",
"../../base:rtc_base",
"../../base:rtc_base_approved",
+ "../../base:rtc_task_queue",
"../../common_audio",
"../../system_wrappers",
"../utility",
]
sources = [
+ "audio_device.cc",
"audio_device_buffer.cc",
"audio_device_buffer.h",
"audio_device_config.h",
"audio_device_generic.cc",
"audio_device_generic.h",
+ "audio_transport.cc",
"dummy/audio_device_dummy.cc",
"dummy/audio_device_dummy.h",
"dummy/file_audio_device.cc",
@@ -210,3 +213,30 @@ source_set("audio_device") {
configs -= [ "//build/config/clang:find_bad_constructs" ]
}
}
+
+# These tests do not work on ios, see
+# https://bugs.chromium.org/p/webrtc/issues/detail?id=4755
+if (!is_ios) {
kjellander_webrtc 2016/08/05 12:47:58 Make this: if (rtc_include_tests && !is_ios) { to
Max Morin WebRTC 2016/08/05 20:58:48 Done.
+ executable("audio_device_tests") {
+ testonly = true
+ sources = [
+ "test/audio_device_test_api.cc",
+ "test/audio_device_test_defines.h",
+ ]
+ deps = [
+ ":audio_device",
+ "../..:webrtc_common",
+ "../../../testing/gtest:gtest",
kjellander_webrtc 2016/08/05 12:47:58 Make this //testing/gtest:gtest or just //testin
Max Morin WebRTC 2016/08/05 20:58:48 Done.
+ "../../system_wrappers",
+ "../../test:test_support",
kjellander_webrtc 2016/08/05 12:47:58 you don't need this if you depend on test_support_
Max Morin WebRTC 2016/08/05 20:58:48 "gn check" warns without it, since audio_device_te
+ "../../test:test_support_main",
+ "../rtp_rtcp",
+ "../utility",
+ ]
+ configs += [ "../..:common_config" ]
+ public_configs = [
+ "../..:common_inherited_config",
+ ":audio_device_config",
+ ]
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698