GYP->GN of audio_device_tests. Remove dead code. Fix new warnings.

webrtc/modules/audio_device/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../../build/webrtc.gni")
 
@@ skipping 11 matching lines @@
     # https://bugs.chromium.org/p/webrtc/issues/detail?id=5748
     cflags = [ "-Wno-thread-safety-analysis" ]
   }
 }
 
 source_set("audio_device") {
   deps = [
     "../..:webrtc_common",
     "../../base:rtc_base",
     "../../base:rtc_base_approved",
+    "../../base:rtc_task_queue",
     "../../common_audio",
     "../../system_wrappers",
     "../utility",
   ]
 
   sources = [
+    "audio_device.cc",
     "audio_device_buffer.cc",
     "audio_device_buffer.h",
     "audio_device_config.h",
     "audio_device_generic.cc",
     "audio_device_generic.h",
+    "audio_transport.cc",
     "dummy/audio_device_dummy.cc",
     "dummy/audio_device_dummy.h",
     "dummy/file_audio_device.cc",
     "dummy/file_audio_device.h",
     "fine_audio_buffer.cc",
     "fine_audio_buffer.h",
     "include/audio_device.h",
     "include/audio_device_defines.h",
   ]
 
@@ skipping 150 matching lines @@
     "../..:common_inherited_config",
     ":audio_device_config",
   ]
 
   if (is_clang) {
     # Suppress warnings from Chrome's Clang plugins.
     # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
     configs -= [ "//build/config/clang:find_bad_constructs" ]
   }
 }
+
+# These tests do not work on ios, see
+# https://bugs.chromium.org/p/webrtc/issues/detail?id=4755
+if (!is_ios) {

[kjellander_webrtc, 2016/08/05 12:47:58]

Make this:
if (rtc_include_tests && !is_ios) {
to prevent Chromium from including the test in its 'all' target.

[Max Morin WebRTC, 2016/08/05 20:58:48]

Done.

+  executable("audio_device_tests") {
+    testonly = true
+    sources = [
+      "test/audio_device_test_api.cc",
+      "test/audio_device_test_defines.h",
+    ]
+    deps = [
+      ":audio_device",
+      "../..:webrtc_common",
+      "../../../testing/gtest:gtest",

[kjellander_webrtc, 2016/08/05 12:47:58]

Make this 
//testing/gtest:gtest
or just 
//testing/gtest 
(which is more common).

The rest needs to be relative, as they're inside the WebRTC repo (needs to be
like that to avoid errors when parsed by a Chromium build)

[Max Morin WebRTC, 2016/08/05 20:58:48]

Done.

+      "../../system_wrappers",
+      "../../test:test_support",

[kjellander_webrtc, 2016/08/05 12:47:58]

you don't need this if you depend on test_support_main.

[Max Morin WebRTC, 2016/08/05 20:58:48]

"gn check" warns without it, since audio_device_test_api.cc includes
webrtc/test/testsupport/fileutils.h, which isn't directly in test_support_main

+      "../../test:test_support_main",
+      "../rtp_rtcp",
+      "../utility",
+    ]
+    configs += [ "../..:common_config" ]
+    public_configs = [
+      "../..:common_inherited_config",
+      ":audio_device_config",
+    ]
+  }
+}