Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2206793007: Revert of Modified PeerConnection and WebRtcSession for end-to-end QuicDataChannel usage. (Closed)

Created:
4 years, 4 months ago by Taylor Brandstetter
Modified:
4 years, 4 months ago
Reviewers:
Zhi Huang, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Modified PeerConnection and WebRtcSession for end-to-end QuicDataChannel usage. (patchset #8 id:280001 of https://codereview.webrtc.org/2166873002/ ) Reason for revert: Reverting because it broke an RTP data channel test on the FYI bots. Original issue's description: > Modified PeerConnection and WebRtcSession for end-to-end QuicDataChannel usage. > > To allow end-to-end QuicDataChannel usage with a > PeerConnection, RTCConfiguration has been modified to > include a boolean for whether to do QUIC, since negotiation of > QUIC is not implemented. If one peer does QUIC, then it will be > assumed that the other peer must do QUIC or the connection > will fail. > > PeerConnection has been modified to create data channels of type > QuicDataChannel when the peer wants to do QUIC. > > WebRtcSession has ben modified to use a QuicDataTransport > instead of a DtlsTransportChannelWrapper/DataChannel > when QUIC should be used > > QuicDataTransport implements the generic functions of > BaseChannel to manage the QuicTransportChannel. > > Committed: https://crrev.com/34b54c36a533dadb6ceb70795119194e6f530ef5 > Cr-Commit-Position: refs/heads/master@{#13645} TBR=pthatcher@webrtc.org,zhihuang@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/907abe44116391fdd8d779f6765aead155fc20a3 Cr-Commit-Position: refs/heads/master@{#13647}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -543 lines) Patch
M webrtc/api/peerconnection.cc View 4 chunks +5 lines, -26 lines 0 comments Download
M webrtc/api/peerconnection_unittest.cc View 12 chunks +24 lines, -107 lines 0 comments Download
M webrtc/api/peerconnectionendtoend_unittest.cc View 4 chunks +2 lines, -83 lines 0 comments Download
M webrtc/api/peerconnectioninterface.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/peerconnectioninterface_unittest.cc View 32 chunks +65 lines, -66 lines 0 comments Download
M webrtc/api/quicdatatransport.h View 5 chunks +6 lines, -28 lines 0 comments Download
M webrtc/api/quicdatatransport.cc View 3 chunks +6 lines, -53 lines 0 comments Download
M webrtc/api/quicdatatransport_unittest.cc View 13 chunks +31 lines, -25 lines 0 comments Download
M webrtc/api/test/peerconnectiontestwrapper.h View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/api/test/peerconnectiontestwrapper.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M webrtc/api/webrtcsession.h View 6 chunks +0 lines, -21 lines 0 comments Download
M webrtc/api/webrtcsession.cc View 11 chunks +13 lines, -78 lines 0 comments Download
M webrtc/api/webrtcsession_unittest.cc View 3 chunks +3 lines, -23 lines 0 comments Download
M webrtc/media/base/mediaengine.h View 1 chunk +5 lines, -1 line 0 comments Download
M webrtc/p2p/base/faketransportcontroller.h View 3 chunks +0 lines, -24 lines 0 comments Download
M webrtc/p2p/quic/quictransportchannel.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Taylor Brandstetter
Created Revert of Modified PeerConnection and WebRtcSession for end-to-end QuicDataChannel usage.
4 years, 4 months ago (2016-08-04 19:22:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2206793007/1
4 years, 4 months ago (2016-08-04 19:22:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 19:22:22 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 19:22:30 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/907abe44116391fdd8d779f6765aead155fc20a3
Cr-Commit-Position: refs/heads/master@{#13647}

Powered by Google App Engine
This is Rietveld 408576698