Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: webrtc/api/quicdatatransport.cc

Issue 2206793007: Revert of Modified PeerConnection and WebRtcSession for end-to-end QuicDataChannel usage. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/quicdatatransport.h ('k') | webrtc/api/quicdatatransport_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/quicdatatransport.cc
diff --git a/webrtc/api/quicdatatransport.cc b/webrtc/api/quicdatatransport.cc
index ff3ac09335320082edeb832ec579e893c254f7b9..c1caf54067ebbfeb6e084b23e69ca679aa5a7cba 100644
--- a/webrtc/api/quicdatatransport.cc
+++ b/webrtc/api/quicdatatransport.cc
@@ -10,48 +10,24 @@
#include "webrtc/api/quicdatatransport.h"
-#include "webrtc/base/bind.h"
#include "webrtc/base/logging.h"
#include "webrtc/p2p/quic/quictransportchannel.h"
#include "webrtc/p2p/quic/reliablequicstream.h"
namespace webrtc {
-QuicDataTransport::QuicDataTransport(
- rtc::Thread* signaling_thread,
- rtc::Thread* worker_thread,
- rtc::Thread* network_thread,
- cricket::TransportController* transport_controller)
+QuicDataTransport::QuicDataTransport(rtc::Thread* signaling_thread,
+ rtc::Thread* worker_thread,
+ rtc::Thread* network_thread)
: signaling_thread_(signaling_thread),
worker_thread_(worker_thread),
- network_thread_(network_thread),
- transport_controller_(transport_controller) {
+ network_thread_(network_thread) {
RTC_DCHECK(signaling_thread_);
RTC_DCHECK(worker_thread_);
RTC_DCHECK(network_thread_);
}
-QuicDataTransport::~QuicDataTransport() {
- DestroyTransportChannel(quic_transport_channel_);
- LOG(LS_INFO) << "Destroyed the QUIC data transport.";
-}
-
-bool QuicDataTransport::SetTransport(const std::string& transport_name) {
- if (transport_name_ == transport_name) {
- // Nothing to do if transport name isn't changing
- return true;
- }
-
- cricket::QuicTransportChannel* transport_channel =
- CreateTransportChannel(transport_name);
- if (!SetTransportChannel(transport_channel)) {
- DestroyTransportChannel(transport_channel);
- return false;
- }
-
- transport_name_ = transport_name;
- return true;
-}
+QuicDataTransport::~QuicDataTransport() {}
bool QuicDataTransport::SetTransportChannel(
cricket::QuicTransportChannel* channel) {
@@ -72,6 +48,7 @@
quic_transport_channel_ = channel;
quic_transport_channel_->SignalIncomingStream.connect(
this, &QuicDataTransport::OnIncomingStream);
+
bool success = true;
for (const auto& kv : data_channel_by_id_) {
rtc::scoped_refptr<QuicDataChannel> data_channel = kv.second;
@@ -170,28 +147,4 @@
data_channel->OnIncomingMessage(std::move(message));
}
-cricket::QuicTransportChannel* QuicDataTransport::CreateTransportChannel(
- const std::string& transport_name) {
- DCHECK(transport_controller_->quic());
-
- cricket::TransportChannel* transport_channel =
- network_thread_->Invoke<cricket::TransportChannel*>(
- RTC_FROM_HERE,
- rtc::Bind(&cricket::TransportController::CreateTransportChannel_n,
- transport_controller_, transport_name,
- cricket::ICE_CANDIDATE_COMPONENT_DEFAULT));
- return static_cast<cricket::QuicTransportChannel*>(transport_channel);
-}
-
-void QuicDataTransport::DestroyTransportChannel(
- cricket::TransportChannel* transport_channel) {
- if (transport_channel) {
- network_thread_->Invoke<void>(
- RTC_FROM_HERE,
- rtc::Bind(&cricket::TransportController::DestroyTransportChannel_n,
- transport_controller_, transport_channel->transport_name(),
- cricket::ICE_CANDIDATE_COMPONENT_DEFAULT));
- }
-}
-
} // namespace webrtc
« no previous file with comments | « webrtc/api/quicdatatransport.h ('k') | webrtc/api/quicdatatransport_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698