Enable socketservers unittests on windows

Enable socketservers unittests on windows.
failing tests disabling moved to ifdefs within the test files from build files.

R=tommi@webrtc.org

Committed: https://crrev.com/e51e11910faddb00921a8bb274f0d9374d55011f
Cr-Commit-Position: refs/heads/master@{#13623}

[danilchap, 2016-08-02 10:23:24]

Description was changed from

==========
Reenable win32socketserver unittests
==========

to

==========
Re-enable socketserverw unittests for windows
==========

[danilchap, 2016-08-02 10:23:39]

Description was changed from

==========
Re-enable socketserverw unittests for windows
==========

to

==========
Re-enable socketservers unittests for windows
==========

[danilchap, 2016-08-02 14:09:55]

Description was changed from

==========
Re-enable socketservers unittests for windows
==========

to

==========
Enable socketservers unittests on windows
==========

[danilchap, 2016-08-02 14:40:50]

Patchset #11 (id:200001) has been deleted

[danilchap, 2016-08-02 15:01:02]

Description was changed from

==========
Enable socketservers unittests on windows
==========

to

==========
Enable socketservers unittests on windows.
failing tests disabling moved to ifdefs within the test files.
==========

[danilchap, 2016-08-02 15:36:14]

Patchset #6 (id:100001) has been deleted

[danilchap, 2016-08-02 15:36:28]

Patchset #2 (id:20001) has been deleted

[danilchap, 2016-08-02 15:36:34]

Patchset #2 (id:40001) has been deleted

[danilchap, 2016-08-02 15:36:41]

Patchset #2 (id:60001) has been deleted

[danilchap, 2016-08-02 15:36:49]

Patchset #2 (id:80001) has been deleted

[danilchap, 2016-08-02 15:37:30]

Patchset #4 (id:160001) has been deleted

[danilchap, 2016-08-02 15:56:47]

Description was changed from

==========
Enable socketservers unittests on windows.
failing tests disabling moved to ifdefs within the test files.
==========

to

==========
Enable socketservers unittests on windows.
failing tests disabling moved to ifdefs within the test files from build files.
==========

[danilchap, 2016-08-03 11:05:56]

The CQ bit was checked by danilchap@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 11:06:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-03 11:22:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 11:22:35]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

[danilchap, 2016-08-03 11:31:41]

danilchap@webrtc.org changed reviewers:
+ tommi@webrtc.org

[danilchap, 2016-08-03 11:31:42]

Can you take a look or recommend a reviewer for socket on windows test code?

This CL fix pbos's TODO:
instead of disabling all socket server tests on windows using build file,
it disables some of them in the _unittest.cc
Few adjustments made to fix compilation on windows.
One more adjustment to make test fail fast instead of fail on 2hour timeout
(test still fail and so is disabled).

[tommi, 2016-08-03 12:55:53]

lgtm. one question below but doesn't make a big 'diff' either way :)

https://codereview.webrtc.org/2199193004/diff/260001/webrtc/base/socket_unitt...
File webrtc/base/socket_unittest.cc (right):

https://codereview.webrtc.org/2199193004/diff/260001/webrtc/base/socket_unitt...
webrtc/base/socket_unittest.cc:684: ptrdiff_t max_send_size) {
out of curiosity, why ptrdiff_t and not e.g. intptr_t?  or even int64_t since it
doesn't look like this is ptr related?

[danilchap, 2016-08-03 13:12:10]

On 2016/08/03 12:55:53, tommi-webrtc wrote:
> lgtm. one question below but doesn't make a big 'diff' either way :)
> 
>
https://codereview.webrtc.org/2199193004/diff/260001/webrtc/base/socket_unitt...
> File webrtc/base/socket_unittest.cc (right):
> 
>
https://codereview.webrtc.org/2199193004/diff/260001/webrtc/base/socket_unitt...
> webrtc/base/socket_unittest.cc:684: ptrdiff_t max_send_size) {
> out of curiosity, why ptrdiff_t and not e.g. intptr_t?  or even int64_t since
it
> doesn't look like this is ptr related?

I was checking what to replace ssize_t with, without checking how it is used.
ssize_t is signed size_t. in c++ prtdiff_t feels most close to that role.

intptr_t looks fitting too, but it feels more like C99, not C++ type.
int64_t is not exactly what is meant here, type expected to be same size as
size_t.

[danilchap, 2016-08-03 13:14:54]

Description was changed from

==========
Enable socketservers unittests on windows.
failing tests disabling moved to ifdefs within the test files from build files.
==========

to

==========
Enable socketservers unittests on windows.
failing tests disabling moved to ifdefs within the test files from build files.

R=tommi@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/e51e11910faddb00921a8bb27...
==========

[danilchap, 2016-08-03 13:14:55]

Committed patchset #7 (id:260001) manually as
e51e11910faddb00921a8bb274f0d9374d55011f (presubmit successful).

[commit-bot: I haz the power, 2016-08-03 13:14:58]

Description was changed from

==========
Enable socketservers unittests on windows.
failing tests disabling moved to ifdefs within the test files from build files.

R=tommi@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/e51e11910faddb00921a8bb27...
==========

to

==========
Enable socketservers unittests on windows.
failing tests disabling moved to ifdefs within the test files from build files.

R=tommi@webrtc.org

Committed: https://crrev.com/e51e11910faddb00921a8bb274f0d9374d55011f
Cr-Commit-Position: refs/heads/master@{#13623}
==========

[ehmaldonado_webrtc, 2016-08-04 14:49:40]

A revert of this CL (patchset #7 id:260001) has been created in
https://codereview.webrtc.org/2209333002/ by ehmaldonado@webrtc.org.

The reason for reverting is: Win64 Debug seems to be broken because of this CL.

https://build.chromium.org/p/client.webrtc/builders/Win64%20Debug


The Win32SocketTest.TestGetSetOptionsIPv4 test is failing with

[ RUN      ] Win32SocketTest.TestGetSetOptionsIPv4
(win32socketserver.cc:299): GetRemoteAddress: unable to get remote addr,
socket=672
(winping.cc:262): IcmpSendEcho(, 65507): 0

Full logs at

https://build.chromium.org/p/client.webrtc/builders/Win64%20Debug/builds/8444...

I filed a bug at https://bugs.chromium.org/p/webrtc/issues/detail?id=6178
.