Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Unified Diff: webrtc/webrtc_tests.gypi

Issue 2199193004: Enable socketservers unittests on windows (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Added tracking bug number Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/webrtc_tests.gypi
diff --git a/webrtc/webrtc_tests.gypi b/webrtc/webrtc_tests.gypi
index 811c4474742894b14b0113daacc846939739fdbc..a05b2141cc84a6f99d2a02d61a3632033686e3e5 100644
--- a/webrtc/webrtc_tests.gypi
+++ b/webrtc/webrtc_tests.gypi
@@ -471,6 +471,9 @@
'type': '<(gtest_target_type)',
'sources': [
'base/nullsocketserver_unittest.cc',
+ 'base/physicalsocketserver_unittest.cc',
+ 'base/socket_unittest.cc',
+ 'base/socket_unittest.h',
'base/socketaddress_unittest.cc',
'base/virtualsocket_unittest.cc',
],
@@ -490,17 +493,7 @@
}],
['OS=="win"', {
'sources': [
- # TODO(ronghuawu): Fix TestUdpReadyToSendIPv6 on windows bot
- # then reenable these tests.
- # 'base/win32socketserver_unittest.cc',
- ],
- }, {
- # TODO(pbos): Move test disabling to ifdefs within the test files
- # instead of here.
- 'sources': [
- 'base/physicalsocketserver_unittest.cc',
- 'base/socket_unittest.cc',
- 'base/socket_unittest.h',
+ 'base/win32socketserver_unittest.cc',
],
}],
['OS=="mac"', {
« webrtc/base/socket_unittest.cc ('K') | « webrtc/base/win32socketserver_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698