Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2193763002: Reland: Add BWE plot to event log analyzer. (Closed)

Created:
4 years, 4 months ago by stefan-webrtc
Modified:
4 years, 4 months ago
Reviewers:
terelius, phoglund
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, pbos-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland: Add BWE plot to event log analyzer. The plot is constructed by actually running the congestion controller with the logged rtp headers and rtcp feedback messages to reproduce the same behavior as in the real call. R=phoglund@webrtc.org, terelius@webrtc.org Committed: https://crrev.com/13181035bcc120fdc9d4d0e35aeabbfa7b67c73e Cr-Commit-Position: refs/heads/master@{#13574}

Patch Set 1 #

Patch Set 2 : Fix issue causing the upstream breakage. #

Patch Set 3 : Fix lib fuzzer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -89 lines) Patch
M webrtc/call/rtc_event_log.h View 1 1 chunk +28 lines, -0 lines 0 comments Download
M webrtc/call/rtc_event_log.cc View 1 2 chunks +9 lines, -34 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/fuzzers/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/test/fuzzers/congestion_controller_feedback_fuzzer.cc View 1 chunk +1 line, -30 lines 0 comments Download
M webrtc/tools/BUILD.gn View 1 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/tools/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/tools/event_log_visualizer/analyzer.h View 3 chunks +25 lines, -8 lines 0 comments Download
M webrtc/tools/event_log_visualizer/analyzer.cc View 9 chunks +181 lines, -15 lines 0 comments Download
M webrtc/tools/event_log_visualizer/generate_timeseries.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M webrtc/tools/event_log_visualizer/plot_base.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/tools/event_log_visualizer/plot_python.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M webrtc/tools/tools.gyp View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
stefan-webrtc
Fix issue causing the upstream breakage.
4 years, 4 months ago (2016-07-29 08:53:59 UTC) #1
stefan-webrtc
This CL broke an upstream build, but I believe it should be fixed in patch-set ...
4 years, 4 months ago (2016-07-29 08:54:53 UTC) #3
phoglund
lgtm
4 years, 4 months ago (2016-07-29 09:09:09 UTC) #8
stefan-webrtc
Fix lib fuzzer.
4 years, 4 months ago (2016-07-29 09:17:39 UTC) #9
terelius
lgtm once libfuzzer is fixed
4 years, 4 months ago (2016-07-29 09:18:23 UTC) #10
stefan-webrtc
4 years, 4 months ago (2016-07-29 12:49:15 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
13181035bcc120fdc9d4d0e35aeabbfa7b67c73e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698