Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Unified Diff: webrtc/call/rtc_event_log.cc

Issue 2193763002: Reland: Add BWE plot to event log analyzer. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fix lib fuzzer. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/call/rtc_event_log.h ('k') | webrtc/modules/congestion_controller/congestion_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/call/rtc_event_log.cc
diff --git a/webrtc/call/rtc_event_log.cc b/webrtc/call/rtc_event_log.cc
index 840b210d15378dbbdf1ee079886674fe6064d27b..c022296730409ca236b25403da9e602698a95cdc 100644
--- a/webrtc/call/rtc_event_log.cc
+++ b/webrtc/call/rtc_event_log.cc
@@ -38,40 +38,6 @@
namespace webrtc {
-// No-op implementation is used if flag is not set, or in tests.
-class RtcEventLogNullImpl final : public RtcEventLog {
- public:
- bool StartLogging(const std::string& file_name,
- int64_t max_size_bytes) override {
- return false;
- }
- bool StartLogging(rtc::PlatformFile platform_file,
- int64_t max_size_bytes) override {
- // The platform_file is open and needs to be closed.
- if (!rtc::ClosePlatformFile(platform_file)) {
- LOG(LS_ERROR) << "Can't close file.";
- }
- return false;
- }
- void StopLogging() override {}
- void LogVideoReceiveStreamConfig(
- const VideoReceiveStream::Config& config) override {}
- void LogVideoSendStreamConfig(
- const VideoSendStream::Config& config) override {}
- void LogRtpHeader(PacketDirection direction,
- MediaType media_type,
- const uint8_t* header,
- size_t packet_length) override {}
- void LogRtcpPacket(PacketDirection direction,
- MediaType media_type,
- const uint8_t* packet,
- size_t length) override {}
- void LogAudioPlayout(uint32_t ssrc) override {}
- void LogBwePacketLossEvent(int32_t bitrate,
- uint8_t fraction_loss,
- int32_t total_packets) override {}
-};
-
#ifdef ENABLE_RTC_EVENT_LOG
class RtcEventLogImpl final : public RtcEventLog {
@@ -454,6 +420,15 @@ bool RtcEventLog::ParseRtcEventLog(const std::string& file_name,
#endif // ENABLE_RTC_EVENT_LOG
+bool RtcEventLogNullImpl::StartLogging(rtc::PlatformFile platform_file,
+ int64_t max_size_bytes) {
+ // The platform_file is open and needs to be closed.
+ if (!rtc::ClosePlatformFile(platform_file)) {
+ LOG(LS_ERROR) << "Can't close file.";
+ }
+ return false;
+}
+
// RtcEventLog member functions.
std::unique_ptr<RtcEventLog> RtcEventLog::Create(const Clock* clock) {
#ifdef ENABLE_RTC_EVENT_LOG
« no previous file with comments | « webrtc/call/rtc_event_log.h ('k') | webrtc/modules/congestion_controller/congestion_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698