Issue 2191863002: Implement CopyOnWriteBuffer move using scoped_refptr move

Issue 2191863002: Implement CopyOnWriteBuffer move using scoped_refptr move (Closed)

Created:
4 years, 4 months ago by danilchap

Modified:
4 years, 4 months ago

Reviewers:
tommi

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

Implement CopyOnWriteBuffer move using scoped_refptr move instead of using temporary swap solution. BUG=webrtc:5556 Committed: https://crrev.com/d8a9c5306b8f6191d0388a68f52e9dd0c2cc287c Cr-Commit-Position: refs/heads/master@{#13582}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -6 lines)			Patch
	M	webrtc/base/copyonwritebuffer.h	View		1 chunk	+1 line, -3 lines	0 comments	Download
	M	webrtc/base/copyonwritebuffer.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 10 (5 generated)

danilchap

with scoped_refptr having move constructor/assignment, CopyOnWriteBuffer can have a straightforward implementation of those.

4 years, 4 months ago (2016-07-29 17:24:12 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2191863002/20001

4 years, 4 months ago (2016-07-30 18:53:33 UTC) #6

commit-bot: I haz the power

4 years, 4 months ago (2016-07-30 19:39:38 UTC) #10

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/d8a9c5306b8f6191d0388a68f52e9dd0c2cc287c
Cr-Commit-Position: refs/heads/master@{#13582}