Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: webrtc/base/copyonwritebuffer.cc

Issue 2191863002: Implement CopyOnWriteBuffer move using scoped_refptr move (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/base/copyonwritebuffer.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2016 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/base/copyonwritebuffer.h" 11 #include "webrtc/base/copyonwritebuffer.h"
12 12
13 namespace rtc { 13 namespace rtc {
14 14
15 CopyOnWriteBuffer::CopyOnWriteBuffer() { 15 CopyOnWriteBuffer::CopyOnWriteBuffer() {
16 RTC_DCHECK(IsConsistent()); 16 RTC_DCHECK(IsConsistent());
17 } 17 }
18 18
19 CopyOnWriteBuffer::CopyOnWriteBuffer(const CopyOnWriteBuffer& buf) 19 CopyOnWriteBuffer::CopyOnWriteBuffer(const CopyOnWriteBuffer& buf)
20 : buffer_(buf.buffer_) { 20 : buffer_(buf.buffer_) {
21 } 21 }
22 22
23 CopyOnWriteBuffer::CopyOnWriteBuffer(CopyOnWriteBuffer&& buf) { 23 CopyOnWriteBuffer::CopyOnWriteBuffer(CopyOnWriteBuffer&& buf)
24 // TODO(jbauch): use std::move once scoped_refptr supports it (issue 5556) 24 : buffer_(std::move(buf.buffer_)) {
25 std::swap(buffer_, buf.buffer_);
26 } 25 }
27 26
28 CopyOnWriteBuffer::CopyOnWriteBuffer(size_t size) 27 CopyOnWriteBuffer::CopyOnWriteBuffer(size_t size)
29 : buffer_(size > 0 ? new RefCountedObject<Buffer>(size) : nullptr) { 28 : buffer_(size > 0 ? new RefCountedObject<Buffer>(size) : nullptr) {
30 RTC_DCHECK(IsConsistent()); 29 RTC_DCHECK(IsConsistent());
31 } 30 }
32 31
33 CopyOnWriteBuffer::CopyOnWriteBuffer(size_t size, size_t capacity) 32 CopyOnWriteBuffer::CopyOnWriteBuffer(size_t size, size_t capacity)
34 : buffer_(size > 0 || capacity > 0 33 : buffer_(size > 0 || capacity > 0
35 ? new RefCountedObject<Buffer>(size, capacity) 34 ? new RefCountedObject<Buffer>(size, capacity)
36 : nullptr) { 35 : nullptr) {
37 RTC_DCHECK(IsConsistent()); 36 RTC_DCHECK(IsConsistent());
38 } 37 }
39 38
40 CopyOnWriteBuffer::~CopyOnWriteBuffer() = default; 39 CopyOnWriteBuffer::~CopyOnWriteBuffer() = default;
41 40
42 } // namespace rtc 41 } // namespace rtc
OLDNEW
« no previous file with comments | « webrtc/base/copyonwritebuffer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698