Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2185533003:
GN migration of target audio_coding/neteq/rtp_analyze. (Closed)
|
Created:
4 years, 4 months ago by aleloi Modified:
4 years, 4 months ago Reviewers:
minyue-webrtc CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc Base URL:
https://chromium.googlesource.com/external/webrtc.git@rtp_analyze_gn Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionGN migration of target audio_coding/neteq/rtp_analyze.
Committed: https://crrev.com/47bded4428ddc49ab75c5697e0b71cf7564e7e83
Cr-Commit-Position: refs/heads/master@{#13533}
Patch Set 1 #
Total comments: 3
Depends on Patchset: Messages
Total messages: 17 (9 generated)
The CQ bit was checked by aleloi@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
aleloi@webrtc.org changed reviewers: + minyue@webrtc.org
Hi! This is part of the ongoing migration effort from GYP to GN. Could you PTAL?
https://codereview.webrtc.org/2185533003/diff/1/webrtc/modules/audio_coding/B... File webrtc/modules/audio_coding/BUILD.gn (right): https://codereview.webrtc.org/2185533003/diff/1/webrtc/modules/audio_coding/B... webrtc/modules/audio_coding/BUILD.gn:1129: deps = [ are these all needed?
https://codereview.webrtc.org/2185533003/diff/1/webrtc/modules/audio_coding/B... File webrtc/modules/audio_coding/BUILD.gn (right): https://codereview.webrtc.org/2185533003/diff/1/webrtc/modules/audio_coding/B... webrtc/modules/audio_coding/BUILD.gn:1129: deps = [ On 2016/07/26 12:23:35, minyue-webrtc wrote: > are these all needed? All but neteq and pcm16b are copied from the corresponding gyp target. I added these two to fix linker errors (somehow, it linked under gyp but not under GN).
lgtm https://codereview.webrtc.org/2185533003/diff/1/webrtc/modules/audio_coding/B... File webrtc/modules/audio_coding/BUILD.gn (right): https://codereview.webrtc.org/2185533003/diff/1/webrtc/modules/audio_coding/B... webrtc/modules/audio_coding/BUILD.gn:1129: deps = [ On 2016/07/26 12:34:51, aleloi wrote: > On 2016/07/26 12:23:35, minyue-webrtc wrote: > > are these all needed? > > All but neteq and pcm16b are copied from the corresponding gyp target. I added > these two to fix linker errors (somehow, it linked under gyp but not under GN). I see, "neteq_unittest_tools" does not depend on "neteq"
The CQ bit was unchecked by aleloi@webrtc.org
The CQ bit was checked by aleloi@webrtc.org
The CQ bit was unchecked by commit-bot@chromium.org
The CQ bit was checked by aleloi@webrtc.org
This CL has an open dependency (Issue 2178353002 Patch 1). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by aleloi@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== GN migration of target audio_coding/neteq/rtp_analyze. ========== to ========== GN migration of target audio_coding/neteq/rtp_analyze. Committed: https://crrev.com/47bded4428ddc49ab75c5697e0b71cf7564e7e83 Cr-Commit-Position: refs/heads/master@{#13533} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/47bded4428ddc49ab75c5697e0b71cf7564e7e83 Cr-Commit-Position: refs/heads/master@{#13533} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
