Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2178353002: GN migration of target audio_coding/neteq/neteq_test_tools (Closed)

Created:
4 years, 4 months ago by aleloi
Modified:
4 years, 4 months ago
Reviewers:
minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN migration of target audio_coding/neteq/neteq_test_tools Committed: https://crrev.com/3022a34e7c6b6dbfb8ac00b77b9c675dc47261dc Cr-Commit-Position: refs/heads/master@{#13531}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 chunk +34 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (11 generated)
aleloi
Hi! This is part of the ongoing migration effort from GYP to GN. Could you ...
4 years, 4 months ago (2016-07-26 12:13:28 UTC) #10
minyue-webrtc
lgtm
4 years, 4 months ago (2016-07-26 13:13:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2178353002/1
4 years, 4 months ago (2016-07-26 13:34:48 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 13:36:07 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 13:36:15 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3022a34e7c6b6dbfb8ac00b77b9c675dc47261dc
Cr-Commit-Position: refs/heads/master@{#13531}

Powered by Google App Engine
This is Rietveld 408576698