Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 2176663002: Don't use LOG_END timestamp to compute RtcEventLog duration. (Closed)

Created:
4 years, 5 months ago by terelius
Modified:
4 years, 4 months ago
Reviewers:
ivoc, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't use LOG_END timestamp to compute RtcEventLog duration. The LOG_END time is incorrect if the event log is stopped by the file size limit instead of a duration limit or a manual stop. This makes the call appear to be very long (10^13 seconds) in the analysis tool. This CL is a workaround for that problem. BUG=webrtc:6138 Committed: https://crrev.com/88c1d2bc0f8468f04cb05a536c5194f9bb9d0e50 Cr-Commit-Position: refs/heads/master@{#13585}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M webrtc/tools/event_log_visualizer/analyzer.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
terelius
4 years, 5 months ago (2016-07-22 14:16:00 UTC) #2
ivoc
LGTM.
4 years, 4 months ago (2016-07-27 09:18:47 UTC) #3
terelius
ping
4 years, 4 months ago (2016-07-29 15:34:33 UTC) #4
stefan-webrtc
lgtm
4 years, 4 months ago (2016-08-01 11:04:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2176663002/1
4 years, 4 months ago (2016-08-01 11:40:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 12:20:36 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 12:20:48 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88c1d2bc0f8468f04cb05a536c5194f9bb9d0e50
Cr-Commit-Position: refs/heads/master@{#13585}

Powered by Google App Engine
This is Rietveld 408576698