Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: webrtc/tools/event_log_visualizer/analyzer.cc

Issue 2176663002: Don't use LOG_END timestamp to compute RtcEventLog duration. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 MediaType media_type; 123 MediaType media_type;
124 uint8_t header[IP_PACKET_SIZE]; 124 uint8_t header[IP_PACKET_SIZE];
125 size_t header_length; 125 size_t header_length;
126 size_t total_length; 126 size_t total_length;
127 127
128 for (size_t i = 0; i < parsed_log_.GetNumberOfEvents(); i++) { 128 for (size_t i = 0; i < parsed_log_.GetNumberOfEvents(); i++) {
129 ParsedRtcEventLog::EventType event_type = parsed_log_.GetEventType(i); 129 ParsedRtcEventLog::EventType event_type = parsed_log_.GetEventType(i);
130 if (event_type != ParsedRtcEventLog::VIDEO_RECEIVER_CONFIG_EVENT && 130 if (event_type != ParsedRtcEventLog::VIDEO_RECEIVER_CONFIG_EVENT &&
131 event_type != ParsedRtcEventLog::VIDEO_SENDER_CONFIG_EVENT && 131 event_type != ParsedRtcEventLog::VIDEO_SENDER_CONFIG_EVENT &&
132 event_type != ParsedRtcEventLog::AUDIO_RECEIVER_CONFIG_EVENT && 132 event_type != ParsedRtcEventLog::AUDIO_RECEIVER_CONFIG_EVENT &&
133 event_type != ParsedRtcEventLog::AUDIO_SENDER_CONFIG_EVENT) { 133 event_type != ParsedRtcEventLog::AUDIO_SENDER_CONFIG_EVENT &&
134 event_type != ParsedRtcEventLog::LOG_START &&
135 event_type != ParsedRtcEventLog::LOG_END) {
134 uint64_t timestamp = parsed_log_.GetTimestamp(i); 136 uint64_t timestamp = parsed_log_.GetTimestamp(i);
135 first_timestamp = std::min(first_timestamp, timestamp); 137 first_timestamp = std::min(first_timestamp, timestamp);
136 last_timestamp = std::max(last_timestamp, timestamp); 138 last_timestamp = std::max(last_timestamp, timestamp);
137 } 139 }
138 140
139 switch (parsed_log_.GetEventType(i)) { 141 switch (parsed_log_.GetEventType(i)) {
140 case ParsedRtcEventLog::VIDEO_RECEIVER_CONFIG_EVENT: { 142 case ParsedRtcEventLog::VIDEO_RECEIVER_CONFIG_EVENT: {
141 VideoReceiveStream::Config config(nullptr); 143 VideoReceiveStream::Config config(nullptr);
142 parsed_log_.GetVideoReceiveConfig(i, &config); 144 parsed_log_.GetVideoReceiveConfig(i, &config);
143 StreamId stream(config.rtp.remote_ssrc, kIncomingPacket, 145 StreamId stream(config.rtp.remote_ssrc, kIncomingPacket,
(...skipping 506 matching lines...) Expand 10 before | Expand all | Expand 10 after
650 plot->yaxis_label = "Bitrate (kbps)"; 652 plot->yaxis_label = "Bitrate (kbps)";
651 if (desired_direction == webrtc::PacketDirection::kIncomingPacket) { 653 if (desired_direction == webrtc::PacketDirection::kIncomingPacket) {
652 plot->title = "Incoming bitrate per stream"; 654 plot->title = "Incoming bitrate per stream";
653 } else if (desired_direction == webrtc::PacketDirection::kOutgoingPacket) { 655 } else if (desired_direction == webrtc::PacketDirection::kOutgoingPacket) {
654 plot->title = "Outgoing bitrate per stream"; 656 plot->title = "Outgoing bitrate per stream";
655 } 657 }
656 } 658 }
657 659
658 } // namespace plotting 660 } // namespace plotting
659 } // namespace webrtc 661 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698