Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2171553002: Convert GN source_set to static_library. (Closed)

Created:
4 years, 5 months ago by brettw
Modified:
4 years, 5 months ago
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc/deps/third_party/openmax.git@master
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Convert GN source_set to static_library. This improves the build time somewhat. BUG=http://crbug.com/627637 R=rtoy@google.com Committed: https://chromium.googlesource.com/external/webrtc/deps/third_party/openmax/+/57d33bee7823e76393692f8d58e0478d6b79d153

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M OWNERS View 1 1 chunk +0 lines, -1 line 0 comments Download
M dl/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
brettw
4 years, 5 months ago (2016-07-20 20:35:51 UTC) #2
Raymond Toy (Google)
lgtm
4 years, 5 months ago (2016-07-20 20:37:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2171553002/20001
4 years, 5 months ago (2016-07-20 20:38:30 UTC) #10
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 5 months ago (2016-07-20 20:38:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2171553002/20001
4 years, 5 months ago (2016-07-20 20:39:08 UTC) #14
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 5 months ago (2016-07-20 20:39:10 UTC) #16
Raymond Toy (Google)
4 years, 5 months ago (2016-07-20 20:44:24 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
57d33bee7823e76393692f8d58e0478d6b79d153 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698