Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2165463006:
Disable NetworkTest.DefaultLocalAddress for Android. (Closed)
|
Created:
4 years, 5 months ago by ehmaldonado_webrtc Modified:
4 years, 5 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionDisable NetworkTest.DefaultLocalAddress for Android.
BUG=4364
R=phoglund@webrtc.org
TBR=mflodman@webrtc.org
Committed: https://crrev.com/8dc945cd3b4fc6855e776631be134d6c079f216c
Cr-Commit-Position: refs/heads/master@{#13505}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Add a comment that explains why the test was disabled. #Messages
Total messages: 23 (10 generated)
ehmaldonado@webrtc.org changed reviewers: + phoglund@webrtc.org
lgtm https://codereview.webrtc.org/2165463006/diff/1/webrtc/base/network_unittest.cc File webrtc/base/network_unittest.cc (right): https://codereview.webrtc.org/2165463006/diff/1/webrtc/base/network_unittest.... webrtc/base/network_unittest.cc:1083: #define MAYBE_DefaultLocalAddress DISABLED_DefaultLocalAddress Add a line above line 1083 with a comment why the test is disabled: // Fails on Android: https://bugs.chromium.org/p/webrtc/issues/detail?id=4364.
The CQ bit was checked by ehmaldonado@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by ehmaldonado@webrtc.org
The CQ bit was checked by ehmaldonado@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from phoglund@webrtc.org Link to the patchset: https://codereview.webrtc.org/2165463006/#ps20001 (title: "Add a comment that explains why the test was disabled.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/6916)
I added the comment and checked the commit box.
** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
webrtc/base/network_unittest.cc
step returned non-zero exit code: 1
Maybe you have to lgtm again?
Aha, we need a rubberstamp from an OWNER here.
On 2016/07/20 14:11:12, phoglund wrote: > Aha, we need a rubberstamp from an OWNER here. It's a good idea to check OWNERs closes to the where the change is. webrtc/base/OWNERS contains henrika@webrtc.org henrikg@webrtc.org hta@webrtc.org jiayl@webrtc.org juberti@webrtc.org mflodman@webrtc.org perkj@webrtc.org pthatcher@webrtc.org sergeyu@chromium.org tommi@webrtc.org Unfortunately almost everyone is on vacation. You can try mflodman maybe. Add him as reviewer and publish+mail again.
ehmaldonado@google.com changed reviewers: + ehmaldonado@google.com, mflodman@webrtc.org
ios64_gn_dbg is failing. Do you think clobber would help or it's something else?
Ok, you know what, add this line TBR=mflodman@webrtc.org to the CL description and go ahead and land it. I think Magnus is busy and all others are on vacation. We need to get the bots green.
Description was changed from ========== Disable NetworkTest.DefaultLocalAddress for Android. BUG=4364 ========== to ========== Disable NetworkTest.DefaultLocalAddress for Android. BUG=4364 TBR=mflodman@webrtc.org ==========
Description was changed from ========== Disable NetworkTest.DefaultLocalAddress for Android. BUG=4364 TBR=mflodman@webrtc.org ========== to ========== Disable NetworkTest.DefaultLocalAddress for Android. BUG=4364 R=phoglund@webrtc.org TBR=mflodman@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/8dc945cd3b4fc6855e776631b... ==========
Message was sent while issue was closed.
Description was changed from ========== Disable NetworkTest.DefaultLocalAddress for Android. BUG=4364 R=phoglund@webrtc.org TBR=mflodman@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/8dc945cd3b4fc6855e776631b... ========== to ========== Disable NetworkTest.DefaultLocalAddress for Android. BUG=4364 R=phoglund@webrtc.org TBR=mflodman@webrtc.org Committed: https://crrev.com/8dc945cd3b4fc6855e776631be134d6c079f216c Cr-Commit-Position: refs/heads/master@{#13505} ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 8dc945cd3b4fc6855e776631be134d6c079f216c (presubmit successful). |
