webrtc/base/network_unittest.cc - Issue 2165463006: Disable NetworkTest.DefaultLocalAddress for Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/network_unittest.cc

Issue 2165463006: Disable NetworkTest.DefaultLocalAddress for Android. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Add a comment that explains why the test was disabled. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/base/network_unittest.cc

diff --git a/webrtc/base/network_unittest.cc b/webrtc/base/network_unittest.cc

index 42e06d08dcc0b604a784d34f25b558e387706231..ab5df738fb8013945db87157abac464b9122d1f2 100644

--- a/webrtc/base/network_unittest.cc

+++ b/webrtc/base/network_unittest.cc

@@ -1079,7 +1079,13 @@ TEST_F(NetworkTest, TestNetworkMonitoring) {

NetworkMonitorFactory::ReleaseFactory(factory);

}

-TEST_F(NetworkTest, DefaultLocalAddress) {

+// Fails on Android: https://bugs.chromium.org/p/webrtc/issues/detail?id=4364.

+#if defined(WEBRTC_ANDROID)

+#define MAYBE_DefaultLocalAddress DISABLED_DefaultLocalAddress

+#else

+#define MAYBE_DefaultLocalAddress DefaultLocalAddress

+#endif

+TEST_F(NetworkTest, MAYBE_DefaultLocalAddress) {

IPAddress ip;

TestBasicNetworkManager manager;

manager.SignalNetworksChanged.connect(static_cast<NetworkTest*>(this),

« no previous file with comments | « no previous file | no next file » | no next file with comments »