Restore the behavior where an ICE restart redetermines the ICE role.

Merge to M53 branch: Restore the behavior where an ICE restart redetermines the ICE role.

We thought we could safely remove this, but older versions of Chrome
don't do role conflict resolution properly, so it's actually not safe
to yet.

BUG=628676
Review-Url: https://codereview.webrtc.org/2152963003
Cr-Commit-Position: refs/heads/master@{#13492}
(cherry picked from commit 91042f834d26986529bf5ac0e2a034a8a8b15524)

R=juberti@webrtc.org
TBR=pthatcher@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/f3010bdf85a0c5432acda813ec8ce402db811e20

[Taylor Brandstetter, 2016-07-18 17:06:19]

Description was changed from

==========
Restore the behavior where an ICE restart redetermines the ICE role.

We thought we could safely remove this, but older versions of Chrome
don't do role conflict resolution properly, so it's actually not safe
to yet.

BUG=628676

Review-Url: https://codereview.webrtc.org/2152963003
Cr-Commit-Position: refs/heads/master@{#13492}
(cherry picked from commit 91042f834d26986529bf5ac0e2a034a8a8b15524)
==========

to

==========
Restore the behavior where an ICE restart redetermines the ICE role.

We thought we could safely remove this, but older versions of Chrome
don't do role conflict resolution properly, so it's actually not safe
to yet.

BUG=628676

Review-Url: https://codereview.webrtc.org/2152963003
Cr-Commit-Position: refs/heads/master@{#13492}
(cherry picked from commit 91042f834d26986529bf5ac0e2a034a8a8b15524)

TBR=pthatcher@webrtc.org
==========

[Taylor Brandstetter, 2016-07-18 17:07:06]

deadbeef@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[Taylor Brandstetter, 2016-07-18 17:07:07]

This is a CL to cherry-pick this change into M53. I'm TBR'ing you since there
was no change from the original CL you reviewed.

[Taylor Brandstetter, 2016-07-18 17:10:27]

Description was changed from

==========
Restore the behavior where an ICE restart redetermines the ICE role.

We thought we could safely remove this, but older versions of Chrome
don't do role conflict resolution properly, so it's actually not safe
to yet.

BUG=628676

Review-Url: https://codereview.webrtc.org/2152963003
Cr-Commit-Position: refs/heads/master@{#13492}
(cherry picked from commit 91042f834d26986529bf5ac0e2a034a8a8b15524)

TBR=pthatcher@webrtc.org
==========

to

==========
Merge to M53 branch: Restore the behavior where an ICE restart redetermines the
ICE role.

We thought we could safely remove this, but older versions of Chrome
don't do role conflict resolution properly, so it's actually not safe
to yet.

BUG=628676

Review-Url: https://codereview.webrtc.org/2152963003
Cr-Commit-Position: refs/heads/master@{#13492}
(cherry picked from commit 91042f834d26986529bf5ac0e2a034a8a8b15524)

TBR=pthatcher@webrtc.org
==========

[Taylor Brandstetter, 2016-07-18 17:23:14]

On 2016/07/18 17:07:07, Taylor Brandstetter wrote:
> This is a CL to cherry-pick this change into M53. I'm TBR'ing you since there
> was no change from the original CL you reviewed.

Oh. I actually do need you to review since M53 branched before I was made an
OWNER.

[Taylor Brandstetter, 2016-07-18 17:29:53]

deadbeef@webrtc.org changed reviewers:
+ juberti@webrtc.org

[Taylor Brandstetter, 2016-07-18 17:29:53]

Adding Justin since Peter is in Berlin and may not be able to review. Needs to
be landed by 4:00 PM today to make the cut.

[Taylor Brandstetter, 2016-07-18 17:29:54]

deadbeef@webrtc.org changed reviewers:
+ juberti@webrtc.org

[Taylor Brandstetter, 2016-07-18 17:29:54]

Adding Justin since Peter is in Berlin and may not be able to review. Needs to
be landed by 4:00 PM today to make the cut.

[juberti1, 2016-07-18 17:41:12]

On 2016/07/18 17:29:54, Taylor Brandstetter wrote:
> Adding Justin since Peter is in Berlin and may not be able to review. Needs to
> be landed by 4:00 PM today to make the cut.

Which versions of Chrome don't handle role conflicts properly?

[juberti1, 2016-07-18 17:41:29]

On 2016/07/18 17:41:12, juberti1 wrote:
> On 2016/07/18 17:29:54, Taylor Brandstetter wrote:
> > Adding Justin since Peter is in Berlin and may not be able to review. Needs
to
> > be landed by 4:00 PM today to make the cut.
> 
> Which versions of Chrome don't handle role conflicts properly?

proactive lgtm

[Taylor Brandstetter, 2016-07-18 17:50:52]

On 2016/07/18 17:41:29, juberti1 wrote:
> On 2016/07/18 17:41:12, juberti1 wrote:
> > On 2016/07/18 17:29:54, Taylor Brandstetter wrote:
> > > Adding Justin since Peter is in Berlin and may not be able to review.
Needs
> to
> > > be landed by 4:00 PM today to make the cut.
> > 
> > Which versions of Chrome don't handle role conflicts properly?
> 
> proactive lgtm

Presumably every version up until now. At least as far back as when I joined (a
year ago). Though it only happens if an ICE restart occurs in the opposite
direction as the initial offer/answer.

[Taylor Brandstetter, 2016-07-18 17:52:38]

Description was changed from

==========
Merge to M53 branch: Restore the behavior where an ICE restart redetermines the
ICE role.

We thought we could safely remove this, but older versions of Chrome
don't do role conflict resolution properly, so it's actually not safe
to yet.

BUG=628676

Review-Url: https://codereview.webrtc.org/2152963003
Cr-Commit-Position: refs/heads/master@{#13492}
(cherry picked from commit 91042f834d26986529bf5ac0e2a034a8a8b15524)

TBR=pthatcher@webrtc.org
==========

to

==========
Merge to M53 branch: Restore the behavior where an ICE restart redetermines the
ICE role.

We thought we could safely remove this, but older versions of Chrome
don't do role conflict resolution properly, so it's actually not safe
to yet.

BUG=628676

Review-Url: https://codereview.webrtc.org/2152963003
Cr-Commit-Position: refs/heads/master@{#13492}
(cherry picked from commit 91042f834d26986529bf5ac0e2a034a8a8b15524)

R=juberti@webrtc.org
TBR=pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/f3010bdf85a0c5432acda813e...
==========

[Taylor Brandstetter, 2016-07-18 17:52:40]

Committed patchset #1 (id:1) manually as
f3010bdf85a0c5432acda813ec8ce402db811e20 (presubmit successful).

[pthatcher1, 2016-07-19 21:00:34]

lgtm