Restore the behavior where an ICE restart redetermines the ICE role.

Restore the behavior where an ICE restart redetermines the ICE role.

We thought we could safely remove this, but older versions of Chrome
don't do role conflict resolution properly, so it's actually not safe
to yet.

BUG=628676
Committed: https://crrev.com/91042f834d26986529bf5ac0e2a034a8a8b15524
Cr-Commit-Position: refs/heads/master@{#13492}

[Taylor Brandstetter, 2016-07-15 17:49:34]

deadbeef@webrtc.org changed reviewers:
+ honghaiz@webrtc.org, pthatcher@webrtc.org

[Taylor Brandstetter, 2016-07-15 17:49:34]

This is a fix for the issue we discussed in our standup yesterday. Please review
as soon as time allows, since we want to try to get this in M53.

[honghaiz3, 2016-07-15 18:22:34]

Would it be safer to just revert the previous webrtc CL that tried not to switch
the role?

Is there an issue if a (mobile) client with this change talks to another client
without this change (but with the previous CL that does not switch the role)?

[Taylor Brandstetter, 2016-07-15 19:22:58]

On 2016/07/15 18:22:34, honghaiz3 wrote:
> Would it be safer to just revert the previous webrtc CL that tried not to
switch
> the role?
> 
> Is there an issue if a (mobile) client with this change talks to another
client
> without this change (but with the previous CL that does not switch the role)?

Ok, we have 3 possibilities:

A: Switches role, doesn't handle conflicts correctly.
B: Switches role, handles conflicts.
C: Doesn't switch role, handles conflicts.

Every combination works except for A<->C.

If I just revert the original CL, then M53 will still have the bug that causes
role conflicts to not work. So it will take even longer to change the role
switch behavior safely. I'm not too worried about mobile clients since this
change has only been committed for a few weeks, and isn't associated with a
Chrome release, so I doubt many third-party developers have picked it up.

[honghaiz3, 2016-07-15 20:30:37]

lgtm to fix the issue in Chrome M53. 

We should have another CL to add a config to allow mobile client to choose
whether to switch the role when an ICE restart happens.

[Taylor Brandstetter, 2016-07-15 20:31:46]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2016-07-15 20:31:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-07-15 20:49:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 20:49:28]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/6873)

[pthatcher1, 2016-07-15 23:20:22]

lgtm

[Taylor Brandstetter, 2016-07-16 00:46:35]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2016-07-16 00:46:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-07-16 00:48:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-16 00:48:27]

Description was changed from

==========
Restore the behavior where an ICE restart redetermines the ICE role.

We thought we could safely remove this, but older versions of Chrome
don't do role conflict resolution properly, so it's actually not safe
to yet.

BUG=628676
==========

to

==========
Restore the behavior where an ICE restart redetermines the ICE role.

We thought we could safely remove this, but older versions of Chrome
don't do role conflict resolution properly, so it's actually not safe
to yet.

BUG=628676

Committed: https://crrev.com/91042f834d26986529bf5ac0e2a034a8a8b15524
Cr-Commit-Position: refs/heads/master@{#13492}
==========

[commit-bot: I haz the power, 2016-07-16 00:48:28]

Patchset 1 (id:??) landed as
https://crrev.com/91042f834d26986529bf5ac0e2a034a8a8b15524
Cr-Commit-Position: refs/heads/master@{#13492}

[Taylor Brandstetter, 2016-07-18 17:09:39]

Description was changed from

==========
Restore the behavior where an ICE restart redetermines the ICE role.

We thought we could safely remove this, but older versions of Chrome
don't do role conflict resolution properly, so it's actually not safe
to yet.

BUG=628676

Committed: https://crrev.com/91042f834d26986529bf5ac0e2a034a8a8b15524
Cr-Commit-Position: refs/heads/master@{#13492}
==========

to

==========
Merge to M53 branch: Restore the behavior where an ICE restart redetermines the
ICE role.

We thought we could safely remove this, but older versions of Chrome
don't do role conflict resolution properly, so it's actually not safe
to yet.

BUG=628676

Committed: https://crrev.com/91042f834d26986529bf5ac0e2a034a8a8b15524
Cr-Commit-Position: refs/heads/master@{#13492}
==========

[Taylor Brandstetter, 2016-07-18 17:10:06]

Description was changed from

==========
Merge to M53 branch: Restore the behavior where an ICE restart redetermines the
ICE role.

We thought we could safely remove this, but older versions of Chrome
don't do role conflict resolution properly, so it's actually not safe
to yet.

BUG=628676

Committed: https://crrev.com/91042f834d26986529bf5ac0e2a034a8a8b15524
Cr-Commit-Position: refs/heads/master@{#13492}
==========

to

==========
Restore the behavior where an ICE restart redetermines the ICE role.

We thought we could safely remove this, but older versions of Chrome
don't do role conflict resolution properly, so it's actually not safe
to yet.

BUG=628676

Committed: https://crrev.com/91042f834d26986529bf5ac0e2a034a8a8b15524
Cr-Commit-Position: refs/heads/master@{#13492}
==========