Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2146133002: Revert of Modify PeerConnection for end-to-end QuicDataChannel usage (Closed)

Created:
4 years, 5 months ago by Taylor Brandstetter
Modified:
4 years, 5 months ago
Reviewers:
Zhi Huang, pthatcher1
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Modify PeerConnection for end-to-end QuicDataChannel usage (patchset #4 id:60001 of https://codereview.webrtc.org/2089553002/ ) Reason for revert: Reverting because description was inaccurate. Will reland after updating description. Original issue's description: > Modify PeerConnection for end-to-end QuicDataChannel usage > > To allow end-to-end QuicDataChannel usage with a > PeerConnection, RTCConfiguration has been modified to > include a boolean for whether to do QUIC, since negotiation of > QUIC is not implemented. If one peer does QUIC, then it will be > assumed that the other peer must do QUIC or the connection > will fail. > > PeerConnection has been modified to create data channels of type > QuicDataChannel when the peer wants to do QUIC. > > WebRtcSession has been modified to use a QuicTransportChannel > instead of a DtlsTransportChannelWrapper/DataChannel > when QUIC should be used. > > Modification of previous in-flight CL: https://codereview.chromium.org/1844803002/ > > Committed: https://crrev.com/36c8d69ce188102ae6fd48c371cf1518f08698fb > Cr-Commit-Position: refs/heads/master@{#13470} TBR=pthatcher@webrtc.org,zhihuang@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a2cd636b3d85321cd8641e196ca16d2129d30cf5 Cr-Commit-Position: refs/heads/master@{#13471}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -45 lines) Patch
M webrtc/api/quicdatachannel.h View 3 chunks +3 lines, -8 lines 0 comments Download
M webrtc/api/quicdatachannel.cc View 6 chunks +10 lines, -12 lines 0 comments Download
M webrtc/api/quicdatachannel_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/api/quicdatatransport.h View 2 chunks +2 lines, -5 lines 0 comments Download
M webrtc/api/quicdatatransport.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M webrtc/api/quicdatatransport_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/p2p/quic/quicsession_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/p2p/quic/quictransportchannel.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/p2p/quic/quictransportchannel.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/p2p/quic/quictransportchannel_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/p2p/quic/reliablequicstream_unittest.cc View 5 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Taylor Brandstetter
Created Revert of Modify PeerConnection for end-to-end QuicDataChannel usage
4 years, 5 months ago (2016-07-13 20:57:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2146133002/1
4 years, 5 months ago (2016-07-13 20:57:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 20:57:37 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 20:57:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2cd636b3d85321cd8641e196ca16d2129d30cf5
Cr-Commit-Position: refs/heads/master@{#13471}

Powered by Google App Engine
This is Rietveld 408576698