Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: webrtc/api/quicdatachannel.h

Issue 2146133002: Revert of Modify PeerConnection for end-to-end QuicDataChannel usage (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/api/quicdatachannel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/quicdatachannel.h
diff --git a/webrtc/api/quicdatachannel.h b/webrtc/api/quicdatachannel.h
index 18a10acbdf66364f8caf21691e193e0e2cbb9802..a6b987b144dd453766c0580b0da7e0f2e0d8b173 100644
--- a/webrtc/api/quicdatachannel.h
+++ b/webrtc/api/quicdatachannel.h
@@ -88,7 +88,6 @@
QuicDataChannel(rtc::Thread* signaling_thread,
rtc::Thread* worker_thread,
- rtc::Thread* network_thread,
const std::string& label,
const DataChannelInit& config);
~QuicDataChannel() override;
@@ -156,13 +155,11 @@
void OnReadyToSend(cricket::TransportChannel* channel);
void OnConnectionClosed();
- // Network thread methods.
+ // Worker thread methods.
// Sends the data buffer to the remote peer using an outgoing QUIC stream.
// Returns true if the data buffer can be successfully sent, or if it is
// queued to be sent later.
- bool Send_n(const DataBuffer& buffer);
-
- // Worker thread methods.
+ bool Send_w(const DataBuffer& buffer);
// Connects the |quic_transport_channel_| signals to this QuicDataChannel,
// then returns the new QuicDataChannel state.
DataState SetTransportChannel_w();
@@ -188,10 +185,8 @@
cricket::QuicTransportChannel* quic_transport_channel_ = nullptr;
// Signaling thread for DataChannelInterface methods.
rtc::Thread* const signaling_thread_;
- // Worker thread for |quic_transport_channel_| callbacks.
+ // Worker thread for sending data and |quic_transport_channel_| callbacks.
rtc::Thread* const worker_thread_;
- // Network thread for sending data and |quic_transport_channel_| callbacks.
- rtc::Thread* const network_thread_;
rtc::AsyncInvoker invoker_;
// Map of QUIC stream ID => ReliableQuicStream* for write blocked QUIC
// streams.
« no previous file with comments | « no previous file | webrtc/api/quicdatachannel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698