Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2145393003: Do not include task_queue.h in sequenced_task_checker_impl.h (Closed)

Created:
4 years, 5 months ago by perkj_webrtc
Modified:
4 years, 5 months ago
Reviewers:
tommi
CC:
tterriberry_mozilla.com, webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Do not include task_queue.h in sequenced_task_checker_impl.h This it to avoid requiring targets that include header files that in turn use SequenceTaskedChecker, to also have to define the macros needed by TaskQueue. BUG=webrtc:5687 Committed: https://crrev.com/32012f8c3a731c8ea98ce75ce617b4d17ea6fa54 Cr-Commit-Position: refs/heads/master@{#13482}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M webrtc/base/sequenced_task_checker_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/sequenced_task_checker_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
perkj_webrtc
please
4 years, 5 months ago (2016-07-14 19:41:29 UTC) #2
tommi
lgtm
4 years, 5 months ago (2016-07-14 20:13:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2145393003/1
4 years, 5 months ago (2016-07-15 06:30:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 06:32:14 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 06:32:24 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32012f8c3a731c8ea98ce75ce617b4d17ea6fa54
Cr-Commit-Position: refs/heads/master@{#13482}

Powered by Google App Engine
This is Rietveld 408576698