Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2140573002: H264VideoToolboxEncoder: Add support for native handles (Closed)

Created:
4 years, 5 months ago by magjed_webrtc
Modified:
4 years, 5 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

H264VideoToolboxEncoder: Add support for native handles Support encoding from CVPixelBuffers directly in H264VideoToolboxEncoder. If the frame needs to be scaled, it will fall back to the previous slow path: CVPixelBuffer -> NV12 -> I420 -> (scale) I420 -> NV12 -> CVPixelBuffer. BUG=webrtc:4081 Committed: https://crrev.com/11dd52bcc69d074f2ea9473fbf95dd42a0cfde1e Cr-Commit-Position: refs/heads/master@{#13439}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -33 lines) Patch
M webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.cc View 3 chunks +51 lines, -33 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
magjed_webrtc
Please take a look.
4 years, 5 months ago (2016-07-11 11:50:43 UTC) #3
tkchin_webrtc
lgtm
4 years, 5 months ago (2016-07-11 18:44:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2140573002/1
4 years, 5 months ago (2016-07-12 07:45:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 08:26:46 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 08:26:56 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11dd52bcc69d074f2ea9473fbf95dd42a0cfde1e
Cr-Commit-Position: refs/heads/master@{#13439}

Powered by Google App Engine
This is Rietveld 408576698