Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2137223002: Prefix bool variable with "should". (Closed)

Created:
4 years, 5 months ago by honghaiz3
Modified:
4 years, 5 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, pthatcher1, Taylor Brandstetter
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Prefix bool variable with "should". This is to address a comment in a CL landed earlier. BUG= Committed: https://crrev.com/af6b6e021ff43b1d96d6decf7e05868d1aff9f61 Cr-Commit-Position: refs/heads/master@{#13435}

Patch Set 1 #

Total comments: 8

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm View 1 4 chunks +9 lines, -8 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h View 1 1 chunk +6 lines, -4 lines 0 comments Download
M webrtc/sdk/objc/Framework/UnitTests/RTCConfigurationTest.mm View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
honghaiz3
4 years, 5 months ago (2016-07-11 19:44:11 UTC) #2
tkchin_webrtc
https://codereview.webrtc.org/2137223002/diff/1/webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm File webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm (right): https://codereview.webrtc.org/2137223002/diff/1/webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm#newcode132 webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm:132: nativeConfig->prune_turn_ports = _shouldPruneTurnPorts; _shouldPruneTurnPorts ? true : false; https://codereview.webrtc.org/2137223002/diff/1/webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm#newcode134 ...
4 years, 5 months ago (2016-07-11 19:52:21 UTC) #3
honghaiz3
PTAL. Thanks! https://codereview.webrtc.org/2137223002/diff/1/webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm File webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm (right): https://codereview.webrtc.org/2137223002/diff/1/webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm#newcode132 webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm:132: nativeConfig->prune_turn_ports = _shouldPruneTurnPorts; On 2016/07/11 19:52:21, tkchin_webrtc ...
4 years, 5 months ago (2016-07-11 20:00:00 UTC) #5
tkchin_webrtc
lgtm thanks
4 years, 5 months ago (2016-07-11 20:48:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2137223002/40001
4 years, 5 months ago (2016-07-11 21:21:02 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 5 months ago (2016-07-11 22:09:30 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 22:09:41 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/af6b6e021ff43b1d96d6decf7e05868d1aff9f61
Cr-Commit-Position: refs/heads/master@{#13435}

Powered by Google App Engine
This is Rietveld 408576698