Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: webrtc/sdk/objc/Framework/UnitTests/RTCConfigurationTest.mm

Issue 2137223002: Prefix bool variable with "should". (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 26 matching lines...) Expand all
37 config.tcpCandidatePolicy = RTCTcpCandidatePolicyDisabled; 37 config.tcpCandidatePolicy = RTCTcpCandidatePolicyDisabled;
38 config.candidateNetworkPolicy = RTCCandidateNetworkPolicyLowCost; 38 config.candidateNetworkPolicy = RTCCandidateNetworkPolicyLowCost;
39 const int maxPackets = 60; 39 const int maxPackets = 60;
40 const int timeout = 1; 40 const int timeout = 1;
41 const int interval = 2; 41 const int interval = 2;
42 config.audioJitterBufferMaxPackets = maxPackets; 42 config.audioJitterBufferMaxPackets = maxPackets;
43 config.iceConnectionReceivingTimeout = timeout; 43 config.iceConnectionReceivingTimeout = timeout;
44 config.iceBackupCandidatePairPingInterval = interval; 44 config.iceBackupCandidatePairPingInterval = interval;
45 config.continualGatheringPolicy = 45 config.continualGatheringPolicy =
46 RTCContinualGatheringPolicyGatherContinually; 46 RTCContinualGatheringPolicyGatherContinually;
47 config.pruneTurnPorts = true; 47 config.shouldPruneTurnPorts = true;
tkchin_webrtc 2016/07/11 19:52:21 YES
honghaiz3 2016/07/11 20:00:00 Done.
48 48
49 std::unique_ptr<webrtc::PeerConnectionInterface::RTCConfiguration> 49 std::unique_ptr<webrtc::PeerConnectionInterface::RTCConfiguration>
50 nativeConfig([config createNativeConfiguration]); 50 nativeConfig([config createNativeConfiguration]);
51 EXPECT_TRUE(nativeConfig.get()); 51 EXPECT_TRUE(nativeConfig.get());
52 EXPECT_EQ(1u, nativeConfig->servers.size()); 52 EXPECT_EQ(1u, nativeConfig->servers.size());
53 webrtc::PeerConnectionInterface::IceServer nativeServer = 53 webrtc::PeerConnectionInterface::IceServer nativeServer =
54 nativeConfig->servers.front(); 54 nativeConfig->servers.front();
55 EXPECT_EQ(1u, nativeServer.urls.size()); 55 EXPECT_EQ(1u, nativeServer.urls.size());
56 EXPECT_EQ("stun:stun1.example.net", nativeServer.urls.front()); 56 EXPECT_EQ("stun:stun1.example.net", nativeServer.urls.front());
57 57
(...skipping 16 matching lines...) Expand all
74 74
75 @end 75 @end
76 76
77 TEST(RTCConfigurationTest, NativeConfigurationConversionTest) { 77 TEST(RTCConfigurationTest, NativeConfigurationConversionTest) {
78 @autoreleasepool { 78 @autoreleasepool {
79 RTCConfigurationTest *test = [[RTCConfigurationTest alloc] init]; 79 RTCConfigurationTest *test = [[RTCConfigurationTest alloc] init];
80 [test testConversionToNativeConfiguration]; 80 [test testConversionToNativeConfiguration];
81 } 81 }
82 } 82 }
83 83
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698