Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2135953002: AVFoundationVideoCapturer: Output native frames instead of I420 frames (Closed)

Created:
4 years, 5 months ago by magjed_webrtc
Modified:
4 years, 5 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

AVFoundationVideoCapturer: Output native frames instead of I420 frames BUG=webrtc:4081 Committed: https://crrev.com/39607c9e3433389db0256d1df4fcdf58a99fedf8 Cr-Commit-Position: refs/heads/master@{#13478}

Patch Set 1 #

Total comments: 4

Patch Set 2 : CVBufferRelease when dropping frame in capturer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -47 lines) Patch
M webrtc/sdk/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm View 1 2 chunks +36 lines, -46 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
magjed_webrtc
Please take a look.
4 years, 5 months ago (2016-07-11 11:51:00 UTC) #5
tkchin_webrtc
How risky is this change? https://codereview.webrtc.org/2135953002/diff/40001/webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm File webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm (right): https://codereview.webrtc.org/2135953002/diff/40001/webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm#newcode663 webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm:663: if (!AdaptFrame(captured_width, captured_height, superclass ...
4 years, 5 months ago (2016-07-11 18:49:01 UTC) #6
magjed_webrtc
> How risky is this change? The only risk I see is if some video ...
4 years, 5 months ago (2016-07-12 14:42:18 UTC) #7
tkchin_webrtc
lgtm
4 years, 5 months ago (2016-07-12 22:00:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2135953002/60001
4 years, 5 months ago (2016-07-14 14:40:22 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 5 months ago (2016-07-14 15:12:22 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 15:12:31 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/39607c9e3433389db0256d1df4fcdf58a99fedf8
Cr-Commit-Position: refs/heads/master@{#13478}

Powered by Google App Engine
This is Rietveld 408576698