webrtc/base/messagequeue.h - Issue 2131503002: Replace reentrant check to be more explicit and avoid a data race when comparing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/messagequeue.h

Issue 2131503002: Replace reentrant check to be more explicit and avoid a data race when comparing (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/base/messagequeue.h

diff --git a/webrtc/base/messagequeue.h b/webrtc/base/messagequeue.h

index 15b98565b770e0eef60563c82e25d3ff4da03c07..a1b20da0e5194ac849b21b5a579418deff04ec1a 100644

--- a/webrtc/base/messagequeue.h

+++ b/webrtc/base/messagequeue.h

@@ -68,8 +68,11 @@ class MessageQueueManager {

static MessageQueueManager* instance_;

// This list contains all live MessageQueues.

- std::vector<MessageQueue *> message_queues_;

+ std::vector<MessageQueue*> message_queues_ GUARDED_BY(crit_);

+ // Acquire this with DebugNonReentrantCritScope.

CriticalSection crit_;

+ bool locked_ GUARDED_BY(crit_);

};

// Derive from this for specialized data

« no previous file with comments | « webrtc/base/criticalsection.h ('k') | webrtc/base/messagequeue.cc » ('j') | no next file with comments »