webrtc/base/criticalsection.h - Issue 2131503002: Replace reentrant check to be more explicit and avoid a data race when comparing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/criticalsection.h

Issue 2131503002: Replace reentrant check to be more explicit and avoid a data race when comparing (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/base/criticalsection.h

diff --git a/webrtc/base/criticalsection.h b/webrtc/base/criticalsection.h

index b06436f7592a97447e7d161b4ecfff68c84a0138..217627eefd08029cf29a6de6eb0c56c77fc881d5 100644

--- a/webrtc/base/criticalsection.h

+++ b/webrtc/base/criticalsection.h

@@ -61,10 +61,10 @@ class LOCKABLE CriticalSection {

bool TryEnter() const EXCLUSIVE_TRYLOCK_FUNCTION(true);

void Leave() const UNLOCK_FUNCTION();

+ private:

// Use only for RTC_DCHECKing.

bool CurrentThreadIsOwner() const;

- private:

#if defined(WEBRTC_WIN)

mutable CRITICAL_SECTION crit_;

#elif defined(WEBRTC_POSIX)

« no previous file with comments | « no previous file | webrtc/base/messagequeue.h » ('j') | no next file with comments »