Updated AudioDecoderFactory to list AudioCodecSpecs instead of SdpAudioFormats.

Updated AudioDecoderFactory to list AudioCodecSpecs instead of SdpAudioFormats.

BUG=webrtc:5805
Committed: https://crrev.com/d4e9f62ea7966a289d19076c7d53b3e1a70c3516
Cr-Commit-Position: refs/heads/master@{#13810}

[ossu, 2016-07-07 09:25:29]

ossu@webrtc.org changed reviewers:
+ ivoc@webrtc.org

[ossu, 2016-07-07 09:25:30]

I've addressed the comfort noise check in this separate CL.
I'll be sharing our design docs with you, so you can see what we're aiming for.

[ivoc, 2016-07-08 13:06:07]

https://codereview.webrtc.org/2123923004/diff/1/webrtc/modules/audio_coding/c...
File webrtc/modules/audio_coding/codecs/audio_format.h (right):

https://codereview.webrtc.org/2123923004/diff/1/webrtc/modules/audio_coding/c...
webrtc/modules/audio_coding/codecs/audio_format.h:53: bool allow_comfort_noise; 
// This encoder can be used with an external
How about just putting this in the SdpAudioFormat class instead? It looks like
it would make the code a bit simpler.

[ossu, 2016-07-08 13:17:13]

https://codereview.webrtc.org/2123923004/diff/1/webrtc/modules/audio_coding/c...
File webrtc/modules/audio_coding/codecs/audio_format.h (right):

https://codereview.webrtc.org/2123923004/diff/1/webrtc/modules/audio_coding/c...
webrtc/modules/audio_coding/codecs/audio_format.h:53: bool allow_comfort_noise; 
// This encoder can be used with an external
On 2016/07/08 13:06:07, ivoc wrote:
> How about just putting this in the SdpAudioFormat class instead? It looks like
> it would make the code a bit simpler. 

No, because it doesn't make sense in SdpAudioFormat. It's information about how
the decoder (and eventually encoder) can be used by the audio coding module, not
about the audio format itself. It doesn't channel any information to/from SDP
nor is it useful information when creating the decoder/encoder.

[ivoc, 2016-07-08 13:37:34]

LGTM.

https://codereview.webrtc.org/2123923004/diff/1/webrtc/modules/audio_coding/c...
File webrtc/modules/audio_coding/codecs/audio_format.h (right):

https://codereview.webrtc.org/2123923004/diff/1/webrtc/modules/audio_coding/c...
webrtc/modules/audio_coding/codecs/audio_format.h:53: bool allow_comfort_noise; 
// This encoder can be used with an external
On 2016/07/08 13:17:12, ossu wrote:
> On 2016/07/08 13:06:07, ivoc wrote:
> > How about just putting this in the SdpAudioFormat class instead? It looks
like
> > it would make the code a bit simpler. 
> 
> No, because it doesn't make sense in SdpAudioFormat. It's information about
how
> the decoder (and eventually encoder) can be used by the audio coding module,
not
> about the audio format itself. It doesn't channel any information to/from SDP
> nor is it useful information when creating the decoder/encoder.

Acknowledged.

[ossu, 2016-07-13 11:02:12]

The CQ bit was checked by ossu@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 11:02:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-07-13 11:57:02]

The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 11:57:03]

Dry run: This issue passed the CQ dry run.

[ossu, 2016-08-17 13:41:42]

The CQ bit was checked by ossu@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 13:41:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-17 15:42:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 15:42:28]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_baremetal on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[ossu, 2016-08-17 16:19:26]

The CQ bit was checked by ossu@webrtc.org

[ossu, 2016-08-17 16:19:26]

The patchset sent to the CQ was uploaded after l-g-t-m from ivoc@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2123923004/#ps20001 (title:
"Rebase")

[commit-bot: I haz the power, 2016-08-17 16:19:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-17 16:37:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 16:37:41]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/7499)

[ossu, 2016-08-17 16:39:23]

ossu@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[ossu, 2016-08-17 16:39:23]

Adding kwiberg as reviewer for owner approval.

[kwiberg-webrtc, 2016-08-17 17:11:29]

lgtm

[ossu, 2016-08-18 08:53:31]

The CQ bit was checked by ossu@webrtc.org

[commit-bot: I haz the power, 2016-08-18 08:53:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-18 09:01:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-18 09:02:24]

Description was changed from

==========
Updated AudioDecoderFactory to list AudioCodecSpecs instead of SdpAudioFormats.

BUG=webrtc:5805
==========

to

==========
Updated AudioDecoderFactory to list AudioCodecSpecs instead of SdpAudioFormats.

BUG=webrtc:5805

Committed: https://crrev.com/d4e9f62ea7966a289d19076c7d53b3e1a70c3516
Cr-Commit-Position: refs/heads/master@{#13810}
==========

[commit-bot: I haz the power, 2016-08-18 09:02:26]

Patchset 2 (id:??) landed as
https://crrev.com/d4e9f62ea7966a289d19076c7d53b3e1a70c3516
Cr-Commit-Position: refs/heads/master@{#13810}