webrtc/modules/audio_coding/codecs/audio_format.h - Issue 2123923004: Updated AudioDecoderFactory to list AudioCodecSpecs instead of SdpAudioFormats.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/audio_format.h

Issue 2123923004: Updated AudioDecoderFactory to list AudioCodecSpecs instead of SdpAudioFormats. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@audio-decoder-factory-usage

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/codecs/audio_decoder_factory.h ('k') | webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/audio_format.h

diff --git a/webrtc/modules/audio_coding/codecs/audio_format.h b/webrtc/modules/audio_coding/codecs/audio_format.h

index 9b971778f8fff42aa04c170688aa841ce022eaf9..43f82dcf04153dc0c24f31227b0f9d775a84dc76 100644

--- a/webrtc/modules/audio_coding/codecs/audio_format.h

+++ b/webrtc/modules/audio_coding/codecs/audio_format.h

@@ -39,12 +39,17 @@ struct SdpAudioFormat {

int clockrate_hz;

int num_channels;

Parameters parameters;

- // Parameters feedback_parameters; ??

};

void swap(SdpAudioFormat& a, SdpAudioFormat& b);

std::ostream& operator<<(std::ostream& os, const SdpAudioFormat& saf);

+struct AudioCodecSpec {

+ SdpAudioFormat format;

+ bool allow_comfort_noise; // This encoder can be used with an external

+ // comfort noise generator.

+};

} // namespace webrtc

#endif // WEBRTC_MODULES_AUDIO_CODING_CODECS_AUDIO_FORMAT_H_