Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2122743003: Fix stats for encoder target bitrate when target rate is zero. (Closed)

Created:
4 years, 5 months ago by perkj_webrtc
Modified:
4 years, 5 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix stats for encoder target bitrate when target rate is zero. When the target bitrate is zero, currently VideoSendStream.Stats.target_media_bitrate_bps show the last set rate before the target was set to zero. BUG=webrtc::5687 b/29574845 Committed: https://crrev.com/f5b2e519b4067e209d2cebbd4b1ef485d2a5c289 Cr-Commit-Position: refs/heads/master@{#13386}

Patch Set 1 #

Patch Set 2 : Removed bad logging. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -74 lines) Patch
M webrtc/modules/video_coding/codec_database.h View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/modules/video_coding/codec_database.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/generic_encoder.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/generic_encoder.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M webrtc/modules/video_coding/include/video_coding.h View 1 chunk +1 line, -7 lines 0 comments Download
M webrtc/modules/video_coding/include/video_coding_defines.h View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.cc View 3 chunks +4 lines, -19 lines 0 comments Download
M webrtc/modules/video_coding/video_receiver.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/video_sender.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/video_coding/video_sender_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 2 chunks +18 lines, -1 line 0 comments Download
M webrtc/video/send_statistics_proxy.h View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/video/send_statistics_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_send_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 4 chunks +13 lines, -1 line 0 comments Download
M webrtc/video/vie_encoder.h View 2 chunks +1 line, -8 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
perkj_webrtc
Can you please review?
4 years, 5 months ago (2016-07-05 09:11:44 UTC) #2
stefan-webrtc
lgtm
4 years, 5 months ago (2016-07-05 09:26:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2122743003/20001
4 years, 5 months ago (2016-07-05 09:50:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 5 months ago (2016-07-05 11:50:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2122743003/20001
4 years, 5 months ago (2016-07-05 15:32:24 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-05 15:34:07 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-05 15:34:09 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 15:34:13 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f5b2e519b4067e209d2cebbd4b1ef485d2a5c289
Cr-Commit-Position: refs/heads/master@{#13386}

Powered by Google App Engine
This is Rietveld 408576698