Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Side by Side Diff: webrtc/modules/video_coding/include/video_coding.h

Issue 2122743003: Fix stats for encoder target bitrate when target rate is zero. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Removed bad logging. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 // introduced as some encoded frames may not be 65 // introduced as some encoded frames may not be
66 // complete. 66 // complete.
67 }; 67 };
68 68
69 class VideoCodingModule : public Module { 69 class VideoCodingModule : public Module {
70 public: 70 public:
71 enum SenderNackMode { kNackNone, kNackAll, kNackSelective }; 71 enum SenderNackMode { kNackNone, kNackAll, kNackSelective };
72 72
73 enum ReceiverRobustness { kNone, kHardNack, kSoftNack, kReferenceSelection }; 73 enum ReceiverRobustness { kNone, kHardNack, kSoftNack, kReferenceSelection };
74 74
75 static VideoCodingModule* Create( 75 static VideoCodingModule* Create(Clock* clock, EventFactory* event_factory);
76 Clock* clock,
77 VideoEncoderRateObserver* encoder_rate_observer,
78 VCMQMSettingsCallback* qm_settings_callback);
79 76
80 static VideoCodingModule* Create( 77 static VideoCodingModule* Create(
81 Clock* clock, 78 Clock* clock,
82 VideoEncoderRateObserver* encoder_rate_observer,
83 VCMQMSettingsCallback* qm_settings_callback, 79 VCMQMSettingsCallback* qm_settings_callback,
84 NackSender* nack_sender, 80 NackSender* nack_sender,
85 KeyFrameRequestSender* keyframe_request_sender, 81 KeyFrameRequestSender* keyframe_request_sender,
86 EncodedImageCallback* pre_decode_image_callback); 82 EncodedImageCallback* pre_decode_image_callback);
87 83
88 static VideoCodingModule* Create(Clock* clock, EventFactory* event_factory);
89
90 static VideoCodingModule* Create( 84 static VideoCodingModule* Create(
91 Clock* clock, 85 Clock* clock,
92 EventFactory* event_factory, 86 EventFactory* event_factory,
93 NackSender* nack_sender, 87 NackSender* nack_sender,
94 KeyFrameRequestSender* keyframe_request_sender); 88 KeyFrameRequestSender* keyframe_request_sender);
95 89
96 // Get supported codec settings using codec type 90 // Get supported codec settings using codec type
97 // 91 //
98 // Input: 92 // Input:
99 // - codecType : The codec type to get settings for 93 // - codecType : The codec type to get settings for
(...skipping 374 matching lines...) Expand 10 before | Expand all | Expand 10 after
474 468
475 virtual void RegisterPostEncodeImageCallback( 469 virtual void RegisterPostEncodeImageCallback(
476 EncodedImageCallback* post_encode_callback) = 0; 470 EncodedImageCallback* post_encode_callback) = 0;
477 // Releases pending decode calls, permitting faster thread shutdown. 471 // Releases pending decode calls, permitting faster thread shutdown.
478 virtual void TriggerDecoderShutdown() = 0; 472 virtual void TriggerDecoderShutdown() = 0;
479 }; 473 };
480 474
481 } // namespace webrtc 475 } // namespace webrtc
482 476
483 #endif // WEBRTC_MODULES_VIDEO_CODING_INCLUDE_VIDEO_CODING_H_ 477 #endif // WEBRTC_MODULES_VIDEO_CODING_INCLUDE_VIDEO_CODING_H_
OLDNEW
« no previous file with comments | « webrtc/modules/video_coding/generic_encoder.cc ('k') | webrtc/modules/video_coding/include/video_coding_defines.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698