Added NiceMock for MockRtcEventLog in several unittests where we don't care about the event logging.

Added NiceMock for MockRtcEventLog in several unittests where we don't care about the event logging.

BUG=webrtc:4741
R=stefan@webrtc.org

Committed: https://crrev.com/fa1d568730ed5dedbed840df0836d1a2fd7a19ee
Cr-Commit-Position: refs/heads/master@{#13388}

[ivoc, 2016-07-05 11:54:03]

Description was changed from

==========
Added NiceMock for MockRtcEventLog in several unittests where we don't care
about the event logging.

BUG=webrtc:4741
==========

to

==========
Added NiceMock for MockRtcEventLog in several unittests where we don't care
about the event logging.

BUG=webrtc:4741
==========

[ivoc, 2016-07-05 11:54:04]

ivoc@webrtc.org changed reviewers:
+ stefan@webrtc.org

[ivoc, 2016-07-05 11:57:19]

Hi Stefan,

Please have a look at this CL to use a NiceMock in several places where we don't
care about the event log.

[stefan-webrtc, 2016-07-05 12:16:27]

lg

https://codereview.webrtc.org/2121993002/diff/1/webrtc/modules/bitrate_contro...
File webrtc/modules/bitrate_controller/bitrate_controller_unittest.cc (right):

https://codereview.webrtc.org/2121993002/diff/1/webrtc/modules/bitrate_contro...
webrtc/modules/bitrate_controller/bitrate_controller_unittest.cc:95:
testing::NiceMock<webrtc::MockRtcEventLog> event_log_;
Given this I think you may be able to remove some of the less interesting
EXPECT_CALL(event_log_, ...) lines below? Or does it make sense to keep all of
them?

[ivoc, 2016-07-05 12:25:27]

https://codereview.webrtc.org/2121993002/diff/1/webrtc/modules/bitrate_contro...
File webrtc/modules/bitrate_controller/bitrate_controller_unittest.cc (right):

https://codereview.webrtc.org/2121993002/diff/1/webrtc/modules/bitrate_contro...
webrtc/modules/bitrate_controller/bitrate_controller_unittest.cc:95:
testing::NiceMock<webrtc::MockRtcEventLog> event_log_;
On 2016/07/05 12:16:27, stefan-webrtc (holmer) wrote:
> Given this I think you may be able to remove some of the less interesting
> EXPECT_CALL(event_log_, ...) lines below? Or does it make sense to keep all of
> them?

Good point, since the purpose of these tests is not really to test the event
log, I decided to just remove them all.

[stefan-webrtc, 2016-07-05 15:30:11]

On 2016/07/05 12:25:27, ivoc wrote:
>
https://codereview.webrtc.org/2121993002/diff/1/webrtc/modules/bitrate_contro...
> File webrtc/modules/bitrate_controller/bitrate_controller_unittest.cc (right):
> 
>
https://codereview.webrtc.org/2121993002/diff/1/webrtc/modules/bitrate_contro...
> webrtc/modules/bitrate_controller/bitrate_controller_unittest.cc:95:
> testing::NiceMock<webrtc::MockRtcEventLog> event_log_;
> On 2016/07/05 12:16:27, stefan-webrtc (holmer) wrote:
> > Given this I think you may be able to remove some of the less interesting
> > EXPECT_CALL(event_log_, ...) lines below? Or does it make sense to keep all
of
> > them?
> 
> Good point, since the purpose of these tests is not really to test the event
> log, I decided to just remove them all.

Lgtm

[ivoc, 2016-07-05 15:55:37]

The CQ bit was checked by ivoc@webrtc.org

[commit-bot: I haz the power, 2016-07-05 15:55:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-07-05 17:56:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-05 17:56:12]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[ivoc, 2016-07-06 07:12:26]

Description was changed from

==========
Added NiceMock for MockRtcEventLog in several unittests where we don't care
about the event logging.

BUG=webrtc:4741
==========

to

==========
Added NiceMock for MockRtcEventLog in several unittests where we don't care
about the event logging.

BUG=webrtc:4741
R=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/fa1d568730ed5dedbed840df0...
==========

[ivoc, 2016-07-06 07:12:28]

Committed patchset #2 (id:20001) manually as
fa1d568730ed5dedbed840df0836d1a2fd7a19ee (presubmit successful).

[commit-bot: I haz the power, 2016-07-06 07:12:30]

Description was changed from

==========
Added NiceMock for MockRtcEventLog in several unittests where we don't care
about the event logging.

BUG=webrtc:4741
R=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/fa1d568730ed5dedbed840df0...
==========

to

==========
Added NiceMock for MockRtcEventLog in several unittests where we don't care
about the event logging.

BUG=webrtc:4741
R=stefan@webrtc.org

Committed: https://crrev.com/fa1d568730ed5dedbed840df0836d1a2fd7a19ee
Cr-Commit-Position: refs/heads/master@{#13388}
==========