webrtc/modules/congestion_controller/congestion_controller_unittest.cc - Issue 2121993002: Added NiceMock for MockRtcEventLog in several unittests where we don't care about the event logging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/congestion_controller/congestion_controller_unittest.cc

Issue 2121993002: Added NiceMock for MockRtcEventLog in several unittests where we don't care about the event logging. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Removed EXPECT_CALL for calls related to RtcEventLog in bitrate_controller_unittest Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/bitrate_controller/bitrate_controller_unittest.cc ('k') | webrtc/modules/remote_bitrate_estimator/test/estimators/remb.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/congestion_controller/congestion_controller_unittest.cc

diff --git a/webrtc/modules/congestion_controller/congestion_controller_unittest.cc b/webrtc/modules/congestion_controller/congestion_controller_unittest.cc

index aa4a5d3330260ba21af47455f6140d63807da18e..ce2258bf5e0a37ad5d2850d4039e063ea0482c2e 100644

--- a/webrtc/modules/congestion_controller/congestion_controller_unittest.cc

+++ b/webrtc/modules/congestion_controller/congestion_controller_unittest.cc

@@ -52,7 +52,7 @@ class CongestionControllerTest : public ::testing::Test {

StrictMock<MockCongestionObserver> observer_;

NiceMock<MockPacedSender>* pacer_;

NiceMock<MockRemoteBitrateObserver> remote_bitrate_observer_;

- MockRtcEventLog event_log_;

+ NiceMock<MockRtcEventLog> event_log_;

std::unique_ptr<RtcpBandwidthObserver> bandwidth_observer_;

std::unique_ptr<CongestionController> controller_;

const uint32_t kInitialBitrateBps = 60000;