Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2119393002: Fixed time moving backwards in the AudioCodingModule. (Closed)

Created:
4 years, 5 months ago by ossu
Modified:
4 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixed time moving backwards in the AudioCodingModule. There was a fast path in PreprocessToAddData that would just use the input timestamps if the input format was equal to the required format of the encoder. This works well as long as the codec never changes. If we are first doing resampling (specifically upsampling) and then change to a codec that does not require resampling, we'll need to stick to whatever input timestamp we left off at, rather than silently accepting whatever we're sent. BUG=622435 Committed: https://crrev.com/63fb95a68d70cd7036db65c3378e91cb77faa44d Cr-Commit-Position: refs/heads/master@{#13398}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated Dtx tests that moved the input timestamp backwards to not do that. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M webrtc/base/checks.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module.cc View 3 chunks +18 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/test/TestVADDTX.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/test/TestVADDTX.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (6 generated)
ossu
PTAL at this. It fixes an error caught by clusterfuzz and is actually something that ...
4 years, 5 months ago (2016-07-05 16:39:04 UTC) #2
tlegrand-webrtc
How is the input timestamp used? I'm asking, since the output timestamp should be updated ...
4 years, 5 months ago (2016-07-06 08:25:44 UTC) #3
ossu
The input timestamp (after being resampled to whatever input sample rate the codec requires) is ...
4 years, 5 months ago (2016-07-06 08:38:56 UTC) #4
tlegrand-webrtc
On 2016/07/06 08:38:56, ossu wrote: > The input timestamp (after being resampled to whatever input ...
4 years, 5 months ago (2016-07-06 08:54:13 UTC) #5
ossu
On 2016/07/06 08:54:13, tlegrand-webrtc wrote: > On 2016/07/06 08:38:56, ossu wrote: > > The input ...
4 years, 5 months ago (2016-07-06 08:57:41 UTC) #6
ossu
On 2016/07/06 08:57:41, ossu wrote: > On 2016/07/06 08:54:13, tlegrand-webrtc wrote: > > On 2016/07/06 ...
4 years, 5 months ago (2016-07-06 09:51:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2119393002/1
4 years, 5 months ago (2016-07-06 09:51:47 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_ubsan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan/builds/3317)
4 years, 5 months ago (2016-07-06 10:00:37 UTC) #11
ossu
On 2016/07/06 10:00:37, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 5 months ago (2016-07-06 10:04:57 UTC) #12
ossu
PTAL. I've updated a test that was failing after this change. I expect it's better ...
4 years, 5 months ago (2016-07-06 11:05:32 UTC) #13
tlegrand
On 2016/07/06 11:05:32, ossu wrote: > PTAL. I've updated a test that was failing after ...
4 years, 5 months ago (2016-07-06 11:19:23 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2119393002/20001
4 years, 5 months ago (2016-07-06 16:32:46 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-06 16:34:26 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 16:34:40 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/63fb95a68d70cd7036db65c3378e91cb77faa44d
Cr-Commit-Position: refs/heads/master@{#13398}

Powered by Google App Engine
This is Rietveld 408576698