Don't silently ignore RNG failures when creating strings / numbers.

Don't silently ignore RNG failures when creating strings / numbers.

RTC_CHECK in functions that return the random value.

BUG=webrtc:6072
Committed: https://crrev.com/912f46a348b2120e7847010095ab74e69758dd80
Cr-Commit-Position: refs/heads/master@{#13682}

[joachim, 2016-07-01 23:12:29]

jbauch@webrtc.org changed reviewers:
+ mattdr@webrtc.org

[joachim, 2016-07-01 23:12:29]

Ptal

https://codereview.webrtc.org/2119003002/diff/1/webrtc/base/helpers.cc
File webrtc/base/helpers.cc (right):

https://codereview.webrtc.org/2119003002/diff/1/webrtc/base/helpers.cc#newcod...
webrtc/base/helpers.cc:313: if (!CreateRandomId(&high) || !CreateRandomId(&low))
{
Maybe get the uint64_t directly from the RNG?

[mattdr-at-webrtc.org, 2016-07-01 23:57:39]

https://codereview.webrtc.org/2119003002/diff/1/webrtc/base/helpers.h
File webrtc/base/helpers.h (right):

https://codereview.webrtc.org/2119003002/diff/1/webrtc/base/helpers.h#newcode43
webrtc/base/helpers.h:43: // WARNING: will abort() if the RNG fails! Use the
version below instead.
Suggest removing these warnings. The RNG will almost never fail, and when it
does something is seriously wrong and the app is probably on its way out anyway.
It's probably not worth it for callers to even consider changing their code.

https://codereview.webrtc.org/2119003002/diff/1/webrtc/base/helpers.h#newcode47
webrtc/base/helpers.h:47: bool CreateRandomUuid(std::string* uuid);
Likewise, no need to increase the surface area by adding another verison of each
function. The extra complexity adds essentially no value.

[joachim, 2016-07-02 00:12:01]

Thanks for your feedback, all changed.

https://codereview.webrtc.org/2119003002/diff/1/webrtc/base/helpers.h
File webrtc/base/helpers.h (right):

https://codereview.webrtc.org/2119003002/diff/1/webrtc/base/helpers.h#newcode43
webrtc/base/helpers.h:43: // WARNING: will abort() if the RNG fails! Use the
version below instead.
On 2016/07/01 23:57:39, mattdr1 wrote:
> Suggest removing these warnings. The RNG will almost never fail, and when it
> does something is seriously wrong and the app is probably on its way out
anyway.
> It's probably not worth it for callers to even consider changing their code.

Done.

https://codereview.webrtc.org/2119003002/diff/1/webrtc/base/helpers.h#newcode47
webrtc/base/helpers.h:47: bool CreateRandomUuid(std::string* uuid);
On 2016/07/01 23:57:39, mattdr1 wrote:
> Likewise, no need to increase the surface area by adding another verison of
each
> function. The extra complexity adds essentially no value.

Done.

[joachim, 2016-07-02 00:14:17]

Description was changed from

==========
Don't silently ignore RNG failures when creating strings / numbers.

RTC_CHECK in functions that return the random value and add functions
returning bool for callers that can handle failures gracefully.

BUG=webrtc:6072
==========

to

==========
Don't silently ignore RNG failures when creating strings / numbers.

RTC_CHECK in functions that return the random value.

BUG=webrtc:6072
==========

[mattdr-at-webrtc.org, 2016-07-02 00:14:27]

LGTM. Thanks!

[joachim, 2016-07-02 00:15:09]

jbauch@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[joachim, 2016-07-02 00:15:10]

+pthatcher for owner review

[joachim, 2016-07-18 10:37:34]

On 2016/07/02 00:15:10, joachim wrote:
> +pthatcher for owner review

Ping?

[joachim, 2016-07-28 11:56:39]

On 2016/07/18 10:37:34, joachim wrote:
> On 2016/07/02 00:15:10, joachim wrote:
> > +pthatcher for owner review
> 
> Ping?

pthatcher, friendly ping

[pthatcher1, 2016-08-08 22:17:56]

lgtm

[joachim, 2016-08-08 22:30:13]

The CQ bit was checked by jbauch@webrtc.org

[commit-bot: I haz the power, 2016-08-08 22:30:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-08 23:33:09]

Description was changed from

==========
Don't silently ignore RNG failures when creating strings / numbers.

RTC_CHECK in functions that return the random value.

BUG=webrtc:6072
==========

to

==========
Don't silently ignore RNG failures when creating strings / numbers.

RTC_CHECK in functions that return the random value.

BUG=webrtc:6072
==========

[commit-bot: I haz the power, 2016-08-08 23:33:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-08 23:33:20]

Description was changed from

==========
Don't silently ignore RNG failures when creating strings / numbers.

RTC_CHECK in functions that return the random value.

BUG=webrtc:6072
==========

to

==========
Don't silently ignore RNG failures when creating strings / numbers.

RTC_CHECK in functions that return the random value.

BUG=webrtc:6072

Committed: https://crrev.com/912f46a348b2120e7847010095ab74e69758dd80
Cr-Commit-Position: refs/heads/master@{#13682}
==========

[commit-bot: I haz the power, 2016-08-08 23:33:21]

Patchset 2 (id:??) landed as
https://crrev.com/912f46a348b2120e7847010095ab74e69758dd80
Cr-Commit-Position: refs/heads/master@{#13682}