webrtc/base/helpers.h - Issue 2119003002: Don't silently ignore RNG failures when creating strings / numbers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/helpers.h

Issue 2119003002: Don't silently ignore RNG failures when creating strings / numbers. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Feedback from Matt. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/base/helpers.h

diff --git a/webrtc/base/helpers.h b/webrtc/base/helpers.h

index 0e7937362a334c7cc29bc9a3ff203c1f7fec647c..690ed39aeb4c84baf4be763105022e708749d1b6 100644

--- a/webrtc/base/helpers.h

+++ b/webrtc/base/helpers.h

@@ -25,7 +25,6 @@ bool InitRandom(const char* seed, size_t len);

// Generates a (cryptographically) random string of the given length.

// We generate base64 values so that they will be printable.

-// WARNING: could silently fail. Use the version below instead.

std::string CreateRandomString(size_t length);

// Generates a (cryptographically) random string of the given length.

« no previous file with comments | « no previous file | webrtc/base/helpers.cc » ('j') | no next file with comments »