Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2117303002:
Minor refactoring of the AudioDeviceBuffer class (Closed)
|
Created:
4 years, 5 months ago by henrika_webrtc Modified:
4 years, 5 months ago Reviewers:
magjed_webrtc CC:
webrtc-reviews_webrtc.org Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionMinor refactoring of the AudioDeviceBuffer class
BUG=NONE
NOTRY=true
Committed: https://crrev.com/3f33e2aa54565e1bf81caec5db4e4b910cf504c1
Cr-Commit-Position: refs/heads/master@{#13389}
Patch Set 1 #Patch Set 2 : nits #Patch Set 3 : Fixes build issue #
Total comments: 2
Patch Set 4 : Feedback from magjed@ #
Messages
Total messages: 22 (11 generated)
Description was changed from ========== Mino refactoring of the AudioDeviceBuffer class BUG= ========== to ========== Minor refactoring of the AudioDeviceBuffer class BUG=NONE ==========
henrika@webrtc.org changed reviewers: + magjed@webrtc.org
Some more cleanup work. Making changes in small steps just in case. No functional changes. Mainly style.
lgtm https://codereview.webrtc.org/2117303002/diff/40001/webrtc/modules/audio_devi... File webrtc/modules/audio_device/audio_device_buffer.cc (right): https://codereview.webrtc.org/2117303002/diff/40001/webrtc/modules/audio_devi... webrtc/modules/audio_device/audio_device_buffer.cc:281: RTC_CHECK(false); nit: RTC_NOTREACHED()
https://codereview.webrtc.org/2117303002/diff/40001/webrtc/modules/audio_devi... File webrtc/modules/audio_device/audio_device_buffer.cc (right): https://codereview.webrtc.org/2117303002/diff/40001/webrtc/modules/audio_devi... webrtc/modules/audio_device/audio_device_buffer.cc:281: RTC_CHECK(false); On 2016/07/05 09:55:47, magjed_webrtc wrote: > nit: RTC_NOTREACHED() Done.
The CQ bit was checked by henrika@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org Link to the patchset: https://codereview.webrtc.org/2117303002/#ps60001 (title: "Feedback from magjed@")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by henrika@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
Description was changed from ========== Minor refactoring of the AudioDeviceBuffer class BUG=NONE ========== to ========== Minor refactoring of the AudioDeviceBuffer class BUG=NONE NOTRY=true ==========
The CQ bit was checked by henrika@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Minor refactoring of the AudioDeviceBuffer class BUG=NONE NOTRY=true ========== to ========== Minor refactoring of the AudioDeviceBuffer class BUG=NONE NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Minor refactoring of the AudioDeviceBuffer class BUG=NONE NOTRY=true ========== to ========== Minor refactoring of the AudioDeviceBuffer class BUG=NONE NOTRY=true Committed: https://crrev.com/3f33e2aa54565e1bf81caec5db4e4b910cf504c1 Cr-Commit-Position: refs/heads/master@{#13389} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/3f33e2aa54565e1bf81caec5db4e4b910cf504c1 Cr-Commit-Position: refs/heads/master@{#13389} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
