Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2117303002: Minor refactoring of the AudioDeviceBuffer class (Closed)

Created:
4 years, 5 months ago by henrika_webrtc
Modified:
4 years, 5 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Minor refactoring of the AudioDeviceBuffer class BUG=NONE NOTRY=true Committed: https://crrev.com/3f33e2aa54565e1bf81caec5db4e4b910cf504c1 Cr-Commit-Position: refs/heads/master@{#13389}

Patch Set 1 #

Patch Set 2 : nits #

Patch Set 3 : Fixes build issue #

Total comments: 2

Patch Set 4 : Feedback from magjed@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -201 lines) Patch
M webrtc/modules/audio_device/audio_device_buffer.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_device/audio_device_buffer.cc View 1 2 3 15 chunks +33 lines, -199 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
henrika_webrtc
Some more cleanup work. Making changes in small steps just in case. No functional changes. ...
4 years, 5 months ago (2016-07-05 09:45:17 UTC) #3
magjed_webrtc
lgtm https://codereview.webrtc.org/2117303002/diff/40001/webrtc/modules/audio_device/audio_device_buffer.cc File webrtc/modules/audio_device/audio_device_buffer.cc (right): https://codereview.webrtc.org/2117303002/diff/40001/webrtc/modules/audio_device/audio_device_buffer.cc#newcode281 webrtc/modules/audio_device/audio_device_buffer.cc:281: RTC_CHECK(false); nit: RTC_NOTREACHED()
4 years, 5 months ago (2016-07-05 09:55:48 UTC) #4
henrika_webrtc
https://codereview.webrtc.org/2117303002/diff/40001/webrtc/modules/audio_device/audio_device_buffer.cc File webrtc/modules/audio_device/audio_device_buffer.cc (right): https://codereview.webrtc.org/2117303002/diff/40001/webrtc/modules/audio_device/audio_device_buffer.cc#newcode281 webrtc/modules/audio_device/audio_device_buffer.cc:281: RTC_CHECK(false); On 2016/07/05 09:55:47, magjed_webrtc wrote: > nit: RTC_NOTREACHED() ...
4 years, 5 months ago (2016-07-05 10:52:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2117303002/60001
4 years, 5 months ago (2016-07-05 10:56:34 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 5 months ago (2016-07-05 12:56:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2117303002/60001
4 years, 5 months ago (2016-07-05 12:58:44 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 5 months ago (2016-07-05 14:59:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2117303002/60001
4 years, 5 months ago (2016-07-06 07:32:20 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-06 07:34:01 UTC) #19
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 07:34:03 UTC) #20
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 07:34:12 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3f33e2aa54565e1bf81caec5db4e4b910cf504c1
Cr-Commit-Position: refs/heads/master@{#13389}

Powered by Google App Engine
This is Rietveld 408576698