webrtc/modules/audio_device/audio_device_buffer.h - Issue 2117303002: Minor refactoring of the AudioDeviceBuffer class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_device/audio_device_buffer.h

Issue 2117303002: Minor refactoring of the AudioDeviceBuffer class (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Feedback from magjed@ Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/audio_device/audio_device_buffer.h

diff --git a/webrtc/modules/audio_device/audio_device_buffer.h b/webrtc/modules/audio_device/audio_device_buffer.h

index 11b49c1100b50881f93e63272849cb76d4a101fa..1267e08be2cfb9696c083e95141c79ebb2917a9a 100644

--- a/webrtc/modules/audio_device/audio_device_buffer.h

+++ b/webrtc/modules/audio_device/audio_device_buffer.h

@@ -28,7 +28,7 @@ class AudioDeviceBuffer {

AudioDeviceBuffer();

virtual ~AudioDeviceBuffer();

- void SetId(uint32_t id);

+ void SetId(uint32_t id) {};

int32_t RegisterAudioCallback(AudioTransport* audioCallback);

int32_t InitPlayout();

@@ -63,7 +63,6 @@ class AudioDeviceBuffer {

int32_t SetTypingStatus(bool typingStatus);

private:

- int32_t _id;

CriticalSectionWrapper& _critSect;

CriticalSectionWrapper& _critSectCb;

« no previous file with comments | « no previous file | webrtc/modules/audio_device/audio_device_buffer.cc » ('j') | no next file with comments »