Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 2112643005: Remove audio/video distinction for probe packets. (Closed)

Created:
4 years, 5 months ago by pbos-webrtc
Modified:
4 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), zhuangzesen_agora.io, Andrew MacDonald, zhengzhonghou_agora.io, henrika_webrtc, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, perkj_webrtc, mflodman, philipel
Base URL:
https://chromium.googlesource.com/external/webrtc.git@52
Target Ref:
refs/pending/branch-heads/52
Project:
webrtc
Visibility:
Public.

Description

Remove audio/video distinction for probe packets. Allows detecting large-enough audio packets as part of a probe, speculative fix for a rampup-time regression in M50. These packets are accounted on the send side when probing. BUG=webrtc:5985 R=philipel@webrtc.org, stefan@webrtc.org, mflodman@webrtc.org TBR=mflodman@webrtc.org Review URL: https://codereview.webrtc.org/2061193002 . Cr-Commit-Position: refs/heads/master@{#13210} (cherry picked from commit a7d88d38448f6a5677a017562765ab505b89d468) BUG=chromium:624374 Committed: https://chromium.googlesource.com/external/webrtc/+/921d16afda7ee9ac2b2389b7c5e5aa909984f399

Patch Set 1 #

Patch Set 2 : rebase errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -188 lines) Patch
M webrtc/audio/audio_receive_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/audio/audio_receive_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/include/mock/mock_remote_bitrate_estimator.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/include/send_time_history.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc View 4 chunks +11 lines, -13 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time_unittest.cc View 11 chunks +13 lines, -19 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc View 1 11 chunks +17 lines, -18 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/send_time_history.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/send_time_history_unittest.cc View 1 9 chunks +34 lines, -42 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/remb.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/packet.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/packet_sender.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/tools/bwe_rtp_play.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter.h View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter_unittest.cc View 5 chunks +17 lines, -19 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h View 3 chunks +6 lines, -14 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M webrtc/video/rtp_stream_receiver.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/channel.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
pbos-webrtc
rebase errors
4 years, 5 months ago (2016-06-30 12:48:00 UTC) #3
pbos-webrtc
PTAL, I had to do a non-trivial rebase so do a proper review :)
4 years, 5 months ago (2016-06-30 12:57:45 UTC) #4
stefan-webrtc
Nothing weird afaict. Please get philip's review too though to be sure. lgtm
4 years, 5 months ago (2016-06-30 13:13:38 UTC) #5
philipel
lgtm to
4 years, 5 months ago (2016-06-30 13:34:26 UTC) #7
pbos-webrtc
Committed patchset #2 (id:20001) manually as 921d16afda7ee9ac2b2389b7c5e5aa909984f399 (presubmit successful).
4 years, 5 months ago (2016-06-30 14:03:35 UTC) #11
mflodman
4 years, 5 months ago (2016-06-30 16:05:57 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698