Remove audio/video distinction for probe packets.

Remove audio/video distinction for probe packets.

Allows detecting large-enough audio packets as part of a probe,
speculative fix for a rampup-time regression in M50. These packets are
accounted on the send side when probing.

BUG=webrtc:5985
R=mflodman@webrtc.org, philipel@webrtc.org

Committed: https://crrev.com/a7d88d38448f6a5677a017562765ab505b89d468
Cr-Commit-Position: refs/heads/master@{#13210}

[pbos-webrtc, 2016-06-14 11:45:43]

PTAL

[pbos-webrtc, 2016-06-14 11:49:47]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-14 11:49:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061193002/1

[pbos-webrtc, 2016-06-14 11:50:45]

FYI all packets are reported on the send side since
https://codereview.webrtc.org/1750403003.

[pbos-webrtc, 2016-06-14 12:12:18]

https://codereview.webrtc.org/2061193002/diff/1/webrtc/modules/remote_bitrate...
File
webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc
(right):

https://codereview.webrtc.org/2061193002/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc:269:
bool was_paced = payload_size > PacedSender::kMinProbePacketSize;
This is the actual change, we no longer care about the was_paced flag (as part
of PacketInfo).

[commit-bot: I haz the power, 2016-06-14 13:22:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 13:22:04]

Dry run: This issue passed the CQ dry run.

[philipel, 2016-06-15 12:14:54]

lgtm

[pbos-webrtc, 2016-06-17 22:21:33]

PTAL :)

[mflodman, 2016-06-20 07:53:44]

LGTM with comment addressed.

https://codereview.webrtc.org/2061193002/diff/1/webrtc/modules/remote_bitrate...
File
webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc
(right):

https://codereview.webrtc.org/2061193002/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc:269:
bool was_paced = payload_size > PacedSender::kMinProbePacketSize;
s/was_paced/probe_packet

Or even better to move this to be part of the if statement on line 281 / move
this to directly above that line.

[pbos-webrtc, 2016-06-20 08:50:52]

rebase + feedback

[pbos-webrtc, 2016-06-20 08:51:23]

Description was changed from

==========
Remove audio/video distinction for probe packets.

Allows detecting large-enough audio packets as part of a probe,
speculative fix for a rampup-time regression in M50. These packets are
accounted on the send side when probing.

BUG=webrtc:5985
R=mflodman@webrtc.org, philipel@webrtc.org
==========

to

==========
Remove audio/video distinction for probe packets.

Allows detecting large-enough audio packets as part of a probe,
speculative fix for a rampup-time regression in M50. These packets are
accounted on the send side when probing.

BUG=webrtc:5985
R=mflodman@webrtc.org, philipel@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/a7d88d38448f6a5677a017562...
==========

[pbos-webrtc, 2016-06-20 08:51:25]

Committed patchset #2 (id:20001) manually as
a7d88d38448f6a5677a017562765ab505b89d468 (presubmit successful).

[commit-bot: I haz the power, 2016-06-20 08:51:27]

Description was changed from

==========
Remove audio/video distinction for probe packets.

Allows detecting large-enough audio packets as part of a probe,
speculative fix for a rampup-time regression in M50. These packets are
accounted on the send side when probing.

BUG=webrtc:5985
R=mflodman@webrtc.org, philipel@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/a7d88d38448f6a5677a017562...
==========

to

==========
Remove audio/video distinction for probe packets.

Allows detecting large-enough audio packets as part of a probe,
speculative fix for a rampup-time regression in M50. These packets are
accounted on the send side when probing.

BUG=webrtc:5985
R=mflodman@webrtc.org, philipel@webrtc.org

Committed: https://crrev.com/a7d88d38448f6a5677a017562765ab505b89d468
Cr-Commit-Position: refs/heads/master@{#13210}
==========

[pbos-webrtc, 2016-06-20 12:18:24]

https://codereview.webrtc.org/2061193002/diff/1/webrtc/modules/remote_bitrate...
File
webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc
(right):

https://codereview.webrtc.org/2061193002/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc:269:
bool was_paced = payload_size > PacedSender::kMinProbePacketSize;
On 2016/06/20 07:53:44, mflodman wrote:
> s/was_paced/probe_packet
> 
> Or even better to move this to be part of the if statement on line 281 / move
> this to directly above that line.

inlined, thanks :)

[honghaiz3, 2016-06-20 18:46:56]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/2086633002/ by honghaiz@webrtc.org.

The reason for reverting is: Revert this because it broke the google3 import
build. 
http://webrtc-buildbot-master.mtv.corp.google.com:21000/builders/WebRTC%20goo....