webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h - Issue 2061193002: Remove audio/video distinction for probe packets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h

Issue 2061193002: Remove audio/video distinction for probe packets. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase + feedback Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter_unittest.cc ('k') | webrtc/modules/rtp_rtcp/source/rtp_sender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h

diff --git a/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h b/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h

index 8875d65081829751572270a4f9788b5f67874c4d..05320f72e1b5a5272bf7c35a2330ce7abe1d6f65 100644

--- a/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h

+++ b/webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h

@@ -251,21 +251,18 @@ struct PacketInfo {

-1,

sequence_number,

- false,

kNotAProbe) {}

PacketInfo(int64_t arrival_time_ms,

int64_t send_time_ms,

uint16_t sequence_number,

size_t payload_size,

- bool was_paced,

int probe_cluster_id)

: PacketInfo(-1,

arrival_time_ms,

send_time_ms,

sequence_number,

payload_size,

- was_paced,

probe_cluster_id) {}

PacketInfo(int64_t creation_time_ms,

@@ -273,14 +270,12 @@ struct PacketInfo {

int64_t send_time_ms,

uint16_t sequence_number,

size_t payload_size,

- bool was_paced,

int probe_cluster_id)

: creation_time_ms(creation_time_ms),

arrival_time_ms(arrival_time_ms),

send_time_ms(send_time_ms),

sequence_number(sequence_number),

payload_size(payload_size),

- was_paced(was_paced),

probe_cluster_id(probe_cluster_id) {}

static constexpr int kNotAProbe = -1;

@@ -298,8 +293,6 @@ struct PacketInfo {

uint16_t sequence_number;

// Size of the packet excluding RTP headers.

size_t payload_size;

- // True if the packet was paced out by the pacer.

- bool was_paced;

// Which probing cluster this packets belongs to.

int probe_cluster_id;

};

@@ -313,7 +306,6 @@ class TransportFeedbackObserver {

// must be set to 0.

virtual void AddPacket(uint16_t sequence_number,

size_t length,

- bool was_paced,

int probe_cluster_id) = 0;

virtual void OnTransportFeedback(const rtcp::TransportFeedback& feedback) = 0;