Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Issue 2111663003: Revert of Add config to prune TURN ports (Closed)

Created:
4 years, 5 months ago by danilchap
Modified:
4 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, juberti1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add config to prune TURN ports (patchset #12 id:360001 of https://codereview.webrtc.org/2093623004/ ) Reason for revert: Breaks Win32/Win64 Debug bots in client.webrtc waterfall Original issue's description: > Add config to prune low-priority TURN ports for creating connections > When the flag prune_turn_ports is set, When a high-priority turn port becomes available, it will prune low-priority ones. The pruned port will not be used for creating connections locally and its candidates will not be sent over to the remove side (unless they have been sent before being pruned). > > This effectively reduces the number of TURN candidates and connections created by TURN ports. > > BUG= > R=deadbeef@webrtc.org, pthatcher@webrtc.org > > Committed: https://crrev.com/17aac053f585e892114974d2eb248e05ad37f973 > Cr-Commit-Position: refs/heads/master@{#13335} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org,honghaiz@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/f4e8cf0d5b68fd16fe3af1e3d83dd8c624677b28 Cr-Commit-Position: refs/heads/master@{#13342}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -401 lines) Patch
M webrtc/api/peerconnection.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/api/peerconnectioninterface.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.cc View 3 chunks +8 lines, -24 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/p2p/base/port_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/p2p/base/portallocator.h View 4 chunks +1 line, -10 lines 0 comments Download
M webrtc/p2p/base/portallocator.cc View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/p2p/base/portallocator_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M webrtc/p2p/base/portinterface.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/p2p/base/relayport.h View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/p2p/base/stunport.h View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/p2p/base/tcpport.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/p2p/base/turnport.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/p2p/client/basicportallocator.h View 4 chunks +2 lines, -18 lines 0 comments Download
M webrtc/p2p/client/basicportallocator.cc View 14 chunks +56 lines, -134 lines 0 comments Download
M webrtc/p2p/client/basicportallocator_unittest.cc View 9 chunks +7 lines, -178 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
danilchap
Created Revert of Add config to prune TURN ports
4 years, 5 months ago (2016-06-30 08:54:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2111663003/1
4 years, 5 months ago (2016-06-30 08:54:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 08:55:07 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 08:55:17 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4e8cf0d5b68fd16fe3af1e3d83dd8c624677b28
Cr-Commit-Position: refs/heads/master@{#13342}

Powered by Google App Engine
This is Rietveld 408576698