Fix to make the start/stop functions for the Rtc Eventlog non-virtual.

Fix to make the start/stop functions for the Rtc Eventlog non-virtual.

This is needed to prevent the Chromium import bot from breaking.

BUG=
R=tommi@webrtc.org

Committed: https://crrev.com/df6ecea8ac7c4c3bddeda089d5fb9eccdf38a0a6
Cr-Commit-Position: refs/heads/master@{#13324}

[ivoc, 2016-06-29 14:48:26]

ivoc@webrtc.org changed reviewers:
+ tommi@webrtc.org

[ivoc, 2016-06-29 14:48:26]

Hi Tommi, please have a look at this small change to make the new functions on
the PeerConnectionInterface non-virtual. This should prevent the import bot from
breaking.

[ivoc, 2016-06-29 14:51:47]

Patchset #2 (id:20001) has been deleted

[tommi, 2016-06-29 14:54:28]

https://codereview.webrtc.org/2107253002/diff/1/webrtc/api/peerconnectioninte...
File webrtc/api/peerconnectioninterface.h (right):

https://codereview.webrtc.org/2107253002/diff/1/webrtc/api/peerconnectioninte...
webrtc/api/peerconnectioninterface.h:498: virtual bool
StartRtcEventLog(rtc::PlatformFile file, int64_t max_size_bytes);
where is the default implementation for the methods?

[tommi, 2016-06-29 14:55:13]

lgtm

https://codereview.webrtc.org/2107253002/diff/40001/webrtc/api/peerconnection...
File webrtc/api/peerconnectioninterface.h (right):

https://codereview.webrtc.org/2107253002/diff/40001/webrtc/api/peerconnection...
webrtc/api/peerconnectioninterface.h:501: }
ah :)

[ivoc, 2016-06-29 14:56:52]

The CQ bit was checked by ivoc@webrtc.org

[commit-bot: I haz the power, 2016-06-29 14:56:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-06-29 15:04:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 15:04:18]

Try jobs failed on following builders:
  android_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14616)

[ivoc, 2016-06-29 15:31:13]

Description was changed from

==========
Fix to make the start/stop functions for the Rtc Eventlog non-virtual.

This is needed to prevent the Chromium import bot from breaking.

BUG=
==========

to

==========
Fix to make the start/stop functions for the Rtc Eventlog non-virtual.

This is needed to prevent the Chromium import bot from breaking.

BUG=
R=tommi@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/df6ecea8ac7c4c3bddeda089d...
==========

[ivoc, 2016-06-29 15:31:14]

Committed patchset #2 (id:40001) manually as
df6ecea8ac7c4c3bddeda089d5fb9eccdf38a0a6 (presubmit successful).

[commit-bot: I haz the power, 2016-06-29 15:31:18]

Description was changed from

==========
Fix to make the start/stop functions for the Rtc Eventlog non-virtual.

This is needed to prevent the Chromium import bot from breaking.

BUG=
R=tommi@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/df6ecea8ac7c4c3bddeda089d...
==========

to

==========
Fix to make the start/stop functions for the Rtc Eventlog non-virtual.

This is needed to prevent the Chromium import bot from breaking.

BUG=
R=tommi@webrtc.org

Committed: https://crrev.com/df6ecea8ac7c4c3bddeda089d5fb9eccdf38a0a6
Cr-Commit-Position: refs/heads/master@{#13324}
==========

[ivoc, 2016-06-30 07:57:20]

A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.webrtc.org/2111803002/ by ivoc@webrtc.org.

The reason for reverting is: Reverting all CLs related to moving the eventlog,
as they break Chromium tests..