Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: webrtc/api/peerconnectioninterface.h

Issue 2107253002: Fix to make the start/stop functions for the Rtc Eventlog non-virtual. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Added empty/default implementation. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/peerconnectioninterface.h
diff --git a/webrtc/api/peerconnectioninterface.h b/webrtc/api/peerconnectioninterface.h
index e57435559e25c6a1254ad46b801afeb91e73f6ff..c72e2ec8af4a7eb89ad41c4fe71d3b9dc7682a38 100644
--- a/webrtc/api/peerconnectioninterface.h
+++ b/webrtc/api/peerconnectioninterface.h
@@ -494,11 +494,15 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
// operation fails the file will be closed. The logging will stop
// automatically after 10 minutes have passed, or when the StopRtcEventLog
// function is called.
+ // TODO(ivoc): Make this pure virtual when Chrome is updated.
virtual bool StartRtcEventLog(rtc::PlatformFile file,
- int64_t max_size_bytes) = 0;
+ int64_t max_size_bytes) {
+ return false;
+ }
tommi 2016/06/29 14:55:13 ah :)
// Stops logging the RtcEventLog.
- virtual void StopRtcEventLog() = 0;
+ // TODO(ivoc): Make this pure virtual when Chrome is updated.
+ virtual void StopRtcEventLog() {}
// Terminates all media and closes the transport.
virtual void Close() = 0;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698