Issue 2107233003: Respect VP8.automaticResizeOn for MediaCodec.

Issue 2107233003: Respect VP8.automaticResizeOn for MediaCodec. (Closed)

Created:
4 years, 5 months ago by pbos-webrtc

Modified:
4 years, 5 months ago

Reviewers:
AlexG

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Respect VP8.automaticResizeOn for MediaCodec. Disables QualityScaler for screenshare-type content and simulcast inside MediaCodecVideoEncoder. BUG= R=glaznev@webrtc.org Committed: https://crrev.com/c5ad0c81c78d6286d8fd6ac14246e444dc68bf8a Cr-Commit-Position: refs/heads/master@{#13347}

Patch Set 1 #

Total comments: 1

Patch Set 2 : feedback #

Patch Set 3 : compile #

Patch Set 4 : bah #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	webrtc/api/java/jni/androidmediaencoder_jni.cc	View	1 2 3	1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

AlexG

lgtm https://codereview.webrtc.org/2107233003/diff/1/webrtc/api/java/jni/androidmediaencoder_jni.cc File webrtc/api/java/jni/androidmediaencoder_jni.cc (right): https://codereview.webrtc.org/2107233003/diff/1/webrtc/api/java/jni/androidmediaencoder_jni.cc#newcode387 webrtc/api/java/jni/androidmediaencoder_jni.cc:387: scale_ = codecType_ == kVideoCodecVP8 ? codec_settings->VP8.automaticResizeOn nit: ...

4 years, 5 months ago (2016-06-30 12:53:44 UTC) #2

pbos-webrtc

4 years, 5 months ago (2016-06-30 14:11:50 UTC) #7

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
c5ad0c81c78d6286d8fd6ac14246e444dc68bf8a (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages