Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: webrtc/api/java/jni/androidmediaencoder_jni.cc

Issue 2107233003: Respect VP8.automaticResizeOn for MediaCodec. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: bah Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/java/jni/androidmediaencoder_jni.cc
diff --git a/webrtc/api/java/jni/androidmediaencoder_jni.cc b/webrtc/api/java/jni/androidmediaencoder_jni.cc
index 49a3fb893d855a7cb1286282aa550d22f86273a7..2c50fe5b01f4c3144a48598058165390b2af0624 100644
--- a/webrtc/api/java/jni/androidmediaencoder_jni.cc
+++ b/webrtc/api/java/jni/androidmediaencoder_jni.cc
@@ -382,7 +382,14 @@ int32_t MediaCodecVideoEncoder::InitEncode(
codec_mode_ = codec_settings->mode;
int init_width = codec_settings->width;
int init_height = codec_settings->height;
- scale_ = codecType_ != kVideoCodecVP9;
+ // Scaling is disabled for VP9, but optionally enabled for VP8.
+ // TODO(pbos): Extract automaticResizeOn out of VP8 settings.
+ scale_ = false;
+ if (codecType_ == kVideoCodecVP8) {
+ scale_ = codec_settings->codecSpecific.VP8.automaticResizeOn;
+ } else if (codecType_ != kVideoCodecVP9) {
+ scale_ = true;
+ }
ALOGD << "InitEncode request: " << init_width << " x " << init_height;
ALOGD << "Encoder automatic resize " << (scale_ ? "enabled" : "disabled");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698