Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2099023002: Fix the turn and udp port type. (Closed)

Created:
4 years, 6 months ago by honghaiz3
Modified:
4 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix the turn and udp port type. The port type was not set if it was created on a shared socket. BUG= R=pthatcher@webrtc.org Committed: https://crrev.com/d00c05788f27e0a58298a0e0ac4132da32ea6ada Cr-Commit-Position: refs/heads/master@{#13313}

Patch Set 1 : . #

Patch Set 2 : Merge with head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -7 lines) Patch
M webrtc/p2p/base/port.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/p2p/base/port.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/p2p/base/stunport.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/p2p/base/stunport_unittest.cc View 6 chunks +14 lines, -7 lines 0 comments Download
M webrtc/p2p/base/turnport.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/p2p/base/turnport_unittest.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2099023002/40001
4 years, 5 months ago (2016-06-27 15:13:35 UTC) #4
honghaiz3
4 years, 5 months ago (2016-06-27 15:14:00 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14506)
4 years, 5 months ago (2016-06-27 15:23:36 UTC) #8
pthatcher1
lgtm
4 years, 5 months ago (2016-06-27 15:42:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2099023002/40001
4 years, 5 months ago (2016-06-28 01:10:53 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/9052) android_dbg on master.tryserver.webrtc (JOB_FAILED, ...
4 years, 5 months ago (2016-06-28 01:14:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2099023002/60001
4 years, 5 months ago (2016-06-28 01:52:04 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14537)
4 years, 5 months ago (2016-06-28 01:58:55 UTC) #18
honghaiz3
4 years, 5 months ago (2016-06-28 16:45:02 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:60001) manually as
d00c05788f27e0a58298a0e0ac4132da32ea6ada (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698