When a remote candidate is added, update all prflx candidates.

When a remote candidate is added, update all prflx candidates.

Previously they were only being updated for connections using the
most current "generation" of ports. This results in the older-
generation prflx candidate pair being prioritized above newer-
generation candidate pairs.

Committed: https://crrev.com/0af180b1aea1c8a0c696b16c5cc6045ed0370fc4
Cr-Commit-Position: refs/heads/master@{#13245}

[Taylor Brandstetter, 2016-06-21 00:33:00]

deadbeef@webrtc.org changed reviewers:
+ honghaiz@webrtc.org, pthatcher@webrtc.org

[Taylor Brandstetter, 2016-06-21 00:33:05]

PTAL Honghai. This is very similar to the issue I recently fixed where the ICE
role wasn't updated on old-generation ports. Instead here, it's the prflx
candidate that wasn't being updated.

https://codereview.webrtc.org/2087713002/diff/1/webrtc/p2p/base/p2ptransportc...
File webrtc/p2p/base/p2ptransportchannel_unittest.cc (left):

https://codereview.webrtc.org/2087713002/diff/1/webrtc/p2p/base/p2ptransportc...
webrtc/p2p/base/p2ptransportchannel_unittest.cc:789: void
set_clear_remote_candidates_ufrag_pwd(bool clear) {
I changed this method for readability. It wasn't clear that
"set_clear_remote_candidates_ufrag_pwd(false)" means SetRemoteIceCredentials is
never used, but several tests depend on this behavior.

[pthatcher1, 2016-06-21 05:42:12]

lgtm

Wow, another good bug found and squashed.

[honghaiz3, 2016-06-21 15:53:47]

lgtm

[Taylor Brandstetter, 2016-06-21 19:40:55]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2016-06-21 19:41:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2087713002/1

[commit-bot: I haz the power, 2016-06-21 20:15:35]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-21 20:15:43]

Description was changed from

==========
When a remote candidate is added, update all prflx candidates.

Previously they were only being updated for connections using the
most current "generation" of ports. This results in the older-
generation prflx candidate pair being prioritized above newer-
generation candidate pairs.
==========

to

==========
When a remote candidate is added, update all prflx candidates.

Previously they were only being updated for connections using the
most current "generation" of ports. This results in the older-
generation prflx candidate pair being prioritized above newer-
generation candidate pairs.

Committed: https://crrev.com/0af180b1aea1c8a0c696b16c5cc6045ed0370fc4
Cr-Commit-Position: refs/heads/master@{#13245}
==========

[commit-bot: I haz the power, 2016-06-21 20:15:44]

Patchset 1 (id:??) landed as
https://crrev.com/0af180b1aea1c8a0c696b16c5cc6045ed0370fc4
Cr-Commit-Position: refs/heads/master@{#13245}