Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 2087713002: When a remote candidate is added, update all prflx candidates. (Closed)

Created:
4 years, 6 months ago by Taylor Brandstetter
Modified:
4 years, 6 months ago
Reviewers:
honghaiz3, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

When a remote candidate is added, update all prflx candidates. Previously they were only being updated for connections using the most current "generation" of ports. This results in the older- generation prflx candidate pair being prioritized above newer- generation candidate pairs. Committed: https://crrev.com/0af180b1aea1c8a0c696b16c5cc6045ed0370fc4 Cr-Commit-Position: refs/heads/master@{#13245}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -15 lines) Patch
M webrtc/p2p/base/p2ptransportchannel.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 9 chunks +72 lines, -12 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
Taylor Brandstetter
PTAL Honghai. This is very similar to the issue I recently fixed where the ICE ...
4 years, 6 months ago (2016-06-21 00:33:05 UTC) #2
pthatcher1
lgtm Wow, another good bug found and squashed.
4 years, 6 months ago (2016-06-21 05:42:12 UTC) #3
honghaiz3
lgtm
4 years, 6 months ago (2016-06-21 15:53:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087713002/1
4 years, 6 months ago (2016-06-21 19:41:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 20:15:35 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 20:15:44 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0af180b1aea1c8a0c696b16c5cc6045ed0370fc4
Cr-Commit-Position: refs/heads/master@{#13245}

Powered by Google App Engine
This is Rietveld 408576698